[PATCH v2] leds: apu: extend support for PC Engines APU1 with newer firmware

2021-02-16 Thread Andreas Eberlein
The DMI_PRODUCT_NAME entry on current firmware of PC Engines APU1 changed from "APU" to "apu1" This modification adds the missing DMI data and thereby the LED support for the PC Engines APU1 with firmware versions >= 4.6.8. Signed-off-by: Andreas Eberlein --- Changes in v2: - Add missing brace

Re: [PATCH v2] leds: apu: extend support for PC Engines APU1 with newer firmware

2021-03-06 Thread Alexander Dahl
Hello, On Wed, Feb 17, 2021 at 12:02:47PM +0100, Enrico Weigelt, metux IT consult wrote: > On 16.02.21 14:30, Andreas Eberlein wrote: > > The DMI_PRODUCT_NAME entry on current firmware of PC Engines APU1 changed > > from "APU" to "apu1" > > > > This modification adds the missing DMI data and the

Re: [PATCH v2] leds: apu: extend support for PC Engines APU1 with newer firmware

2021-02-23 Thread Enrico Weigelt, metux IT consult
On 19.02.21 21:51, Zbyněk Kocur wrote: Hi Zbyněk, Thanks for adding to the discussion. I tested the proposed modification on APU1 with different versions of bios. The LED subsystem now behaves the same as the APU2 and higher. If it needs more tests on various boards from PCengines, I'm avai

Re: [PATCH v2] leds: apu: extend support for PC Engines APU1 with newer firmware

2021-02-23 Thread Zbyněk Kocur
Hello, I checked my stock and I have following models: - apu2e2 - apu2e4 - apu3d4 - apu4c4 The bios in all models can be upgraded from version 4.0.6 to higher. The latest is 4.13.0.3. Zbyněk --- email: zbynek.ko...@fel.cvut.cz mobile: +420 728 946 803 phone: +420 224 354 054 web: https://comte

Re: [PATCH v2] leds: apu: extend support for PC Engines APU1 with newer firmware

2021-03-18 Thread Enrico Weigelt, metux IT consult
On 06.03.21 17:51, Alexander Dahl wrote: Hi, If you give me a hint, which tree or patchset should be tested, and some hints what should be tested, I can try. haven't written anything for apu1 yet (as I dont have one), but I wrote the drivers for apu2/3/4. My idea (which I never actually star

Re: [PATCH v2] leds: apu: extend support for PC Engines APU1 with newer firmware

2021-02-19 Thread Pavel Machek
> > MODULE_DEVICE_TABLE(dmi, apu_led_dmi_table); > > @@ -173,7 +182,7 @@ static int __init apu_led_init(void) > > int err; > > if (!(dmi_match(DMI_SYS_VENDOR, "PC Engines") && > > - dmi_match(DMI_PRODUCT_NAME, "APU"))) { > > + (dmi_match(DMI_PRODUCT_NAME, "APU") || > > dm

Re: [PATCH v2] leds: apu: extend support for PC Engines APU1 with newer firmware

2021-02-19 Thread Petr Štetiar
Enrico Weigelt, metux IT consult [2021-02-17 12:02:47]: Hi, (adding Zbynek to Cc: who seems to own a complete range of APU boards and has done the runtime testing already) > Looks good to me. But don't dare giving official ack, since I don't > have an apu1 board for testing. @Zbynek can you pe

Re: [PATCH v2] leds: apu: extend support for PC Engines APU1 with newer firmware

2021-02-19 Thread Zbyněk Kocur
Petr Štetiar Hi Peter, Thanks for adding to the discussion. I tested the proposed modification on APU1 with different versions of bios. The LED subsystem now behaves the same as the APU2 and higher. If it needs more tests on various boards from PCengines, I'm available. Tested-by: Zbyněk

Re: [PATCH v2] leds: apu: extend support for PC Engines APU1 with newer firmware

2021-02-19 Thread Zbyněk Kocur
Petr Štetiar Hi Peter, Thanks for adding to the discussion. I tested the proposed modification on APU1 with different versions of bios. The LED subsystem now behaves the same as the APU2 and higher. If it needs more tests on various boards from PCengines, I'm available. Tested-by: Zbyněk K

Re: [PATCH v2] leds: apu: extend support for PC Engines APU1 with newer firmware

2021-02-17 Thread Enrico Weigelt, metux IT consult
On 16.02.21 14:30, Andreas Eberlein wrote: Hi, The DMI_PRODUCT_NAME entry on current firmware of PC Engines APU1 changed from "APU" to "apu1" This modification adds the missing DMI data and thereby the LED support for the PC Engines APU1 with firmware versions >= 4.6.8. Do you have a device