Re: [PATCH v2] leds: fix brightness changing when software blinking is active

2015-06-24 Thread Jacek Anaszewski
On 06/24/2015 10:44 AM, Pavel Machek wrote: On Tue 2015-06-23 19:59:27, Stas Sergeev wrote: 02.05.2015 17:59, Pavel Machek пишет: On Thu 2015-05-14 18:24:02, Stas Sergeev wrote: The following sequence: echo timer >/sys/class/leds//trigger echo 1 >/sys/class/leds//brightness should change the

Re: [PATCH v2] leds: fix brightness changing when software blinking is active

2015-06-24 Thread Pavel Machek
On Tue 2015-06-23 19:59:27, Stas Sergeev wrote: > 02.05.2015 17:59, Pavel Machek пишет: > > On Thu 2015-05-14 18:24:02, Stas Sergeev wrote: > >> > >> The following sequence: > >> echo timer >/sys/class/leds//trigger > >> echo 1 >/sys/class/leds//brightness > >> should change the ON brightness for b

Re: [PATCH v2] leds: fix brightness changing when software blinking is active

2015-06-23 Thread Stas Sergeev
02.05.2015 17:59, Pavel Machek пишет: > On Thu 2015-05-14 18:24:02, Stas Sergeev wrote: >> >> The following sequence: >> echo timer >/sys/class/leds//trigger >> echo 1 >/sys/class/leds//brightness >> should change the ON brightness for blinking. >> The function led_set_brightness() was mistakenly i

Re: [PATCH v2] leds: fix brightness changing when software blinking is active

2015-06-23 Thread Pavel Machek
On Thu 2015-05-14 18:24:02, Stas Sergeev wrote: > > The following sequence: > echo timer >/sys/class/leds//trigger > echo 1 >/sys/class/leds//brightness > should change the ON brightness for blinking. > The function led_set_brightness() was mistakenly initiating the > delayed blink stop procedure,

Re: [PATCH v2] leds: fix brightness changing when software blinking is active

2015-05-19 Thread Bryan Wu
On Fri, May 15, 2015 at 7:41 AM, Jacek Anaszewski wrote: > On 05/15/2015 04:11 PM, Stas Sergeev wrote: >> >> 15.05.2015 17:09, Jacek Anaszewski пишет: >>> >>> On 05/15/2015 10:12 AM, Jacek Anaszewski wrote: Hi Stas, On 05/14/2015 05:24 PM, Stas Sergeev wrote: > > >

Re: [PATCH v2] leds: fix brightness changing when software blinking is active

2015-05-15 Thread Jacek Anaszewski
On 05/15/2015 04:11 PM, Stas Sergeev wrote: 15.05.2015 17:09, Jacek Anaszewski пишет: On 05/15/2015 10:12 AM, Jacek Anaszewski wrote: Hi Stas, On 05/14/2015 05:24 PM, Stas Sergeev wrote: The following sequence: echo timer >/sys/class/leds//trigger echo 1 >/sys/class/leds//brightness should c

Re: [PATCH v2] leds: fix brightness changing when software blinking is active

2015-05-15 Thread Stas Sergeev
15.05.2015 17:09, Jacek Anaszewski пишет: > On 05/15/2015 10:12 AM, Jacek Anaszewski wrote: >> Hi Stas, >> >> On 05/14/2015 05:24 PM, Stas Sergeev wrote: >>> >>> The following sequence: >>> echo timer >/sys/class/leds//trigger >>> echo 1 >/sys/class/leds//brightness >>> should change the ON brightn

Re: [PATCH v2] leds: fix brightness changing when software blinking is active

2015-05-15 Thread Jacek Anaszewski
On 05/15/2015 10:12 AM, Jacek Anaszewski wrote: Hi Stas, On 05/14/2015 05:24 PM, Stas Sergeev wrote: The following sequence: echo timer >/sys/class/leds//trigger echo 1 >/sys/class/leds//brightness should change the ON brightness for blinking. The function led_set_brightness() was mistakenly i

Re: [PATCH v2] leds: fix brightness changing when software blinking is active

2015-05-15 Thread Jacek Anaszewski
Hi Stas, On 05/14/2015 05:24 PM, Stas Sergeev wrote: The following sequence: echo timer >/sys/class/leds//trigger echo 1 >/sys/class/leds//brightness should change the ON brightness for blinking. The function led_set_brightness() was mistakenly initiating the delayed blink stop procedure, which

[PATCH v2] leds: fix brightness changing when software blinking is active

2015-05-14 Thread Stas Sergeev
The following sequence: echo timer >/sys/class/leds//trigger echo 1 >/sys/class/leds//brightness should change the ON brightness for blinking. The function led_set_brightness() was mistakenly initiating the delayed blink stop procedure, which resulted in no blinking with the timer trigger still ac