Re: [PATCH v2] leds: pca955x: Don't invert requested value in pca955x_gpio_set_value()

2017-09-08 Thread Jacek Anaszewski
Hi Andrew, Thanks for the patch. On 09/01/2017 07:38 AM, Andrew Jeffery wrote: > The PCA9552 lines can be used either for driving LEDs or as GPIOs. The > manual states that for LEDs, the operation is open-drain: > > The LSn LED select registers determine the source of the LED data. > >

Re: [PATCH v2] leds: pca955x: Don't invert requested value in pca955x_gpio_set_value()

2017-09-07 Thread Joel Stanley
On Sat, Sep 2, 2017 at 2:36 AM, Cédric Le Goater wrote: > On 09/01/2017 07:38 AM, Andrew Jeffery wrote: >> Rework leds-pca955x so that we avoid the incorrect inversion and clarify >> the semantics with respect to GPIO. >> >> Signed-off-by: Andrew Jeffery > > Reviewed-by: Cédric Le Goater I gav

Re: [PATCH v2] leds: pca955x: Don't invert requested value in pca955x_gpio_set_value()

2017-09-01 Thread Cédric Le Goater
On 09/01/2017 07:38 AM, Andrew Jeffery wrote: > The PCA9552 lines can be used either for driving LEDs or as GPIOs. The > manual states that for LEDs, the operation is open-drain: > > The LSn LED select registers determine the source of the LED data. > >00 = output is set LOW

[PATCH v2] leds: pca955x: Don't invert requested value in pca955x_gpio_set_value()

2017-08-31 Thread Andrew Jeffery
The PCA9552 lines can be used either for driving LEDs or as GPIOs. The manual states that for LEDs, the operation is open-drain: The LSn LED select registers determine the source of the LED data. 00 = output is set LOW (LED on) 01 = output is set high-impedance (LED