Re: [PATCH v2] media:dvb-frontends:Remove dvb_pll_devcount and id module parameters.

2019-08-02 Thread Sean Young
On Fri, Aug 02, 2019 at 12:20:19PM +0530, Vandana BN wrote: > > On 01/08/19 2:31 PM, Michael Ira Krufky wrote: > > Sean, > > > > Please pardon the late reply. See my responses inline below: > > > > On Wed, Jul 24, 2019 at 1:36 AM Sean Young wrote: > >> On Sat, Jul 20, 2019 at 11:43:02AM +0530,

Re: [PATCH v2] media:dvb-frontends:Remove dvb_pll_devcount and id module parameters.

2019-08-01 Thread Vandana BN
On 01/08/19 2:31 PM, Michael Ira Krufky wrote: > Sean, > > Please pardon the late reply. See my responses inline below: > > On Wed, Jul 24, 2019 at 1:36 AM Sean Young wrote: >> On Sat, Jul 20, 2019 at 11:43:02AM +0530, Vandana BN wrote: >>> Syzbot reported global-out-of-bounds Read in dvb_pll_

Re: [PATCH v2] media:dvb-frontends:Remove dvb_pll_devcount and id module parameters.

2019-08-01 Thread Michael Ira Krufky
Sean, Please pardon the late reply. See my responses inline below: On Wed, Jul 24, 2019 at 1:36 AM Sean Young wrote: > > On Sat, Jul 20, 2019 at 11:43:02AM +0530, Vandana BN wrote: > > Syzbot reported global-out-of-bounds Read in dvb_pll_attach, while > > accessing id[dvb_pll_devcount], becaus

Re: [PATCH v2] media:dvb-frontends:Remove dvb_pll_devcount and id module parameters.

2019-08-01 Thread Vandana BN
On 01/08/19 10:39 AM, Sean Young wrote: > On Wed, Jul 24, 2019 at 06:36:35AM +0100, Sean Young wrote: >> On Sat, Jul 20, 2019 at 11:43:02AM +0530, Vandana BN wrote: >>> Syzbot reported global-out-of-bounds Read in dvb_pll_attach, while >>> accessing id[dvb_pll_devcount], because dvb_pll_devcount

Re: [PATCH v2] media:dvb-frontends:Remove dvb_pll_devcount and id module parameters.

2019-07-31 Thread Sean Young
On Wed, Jul 24, 2019 at 06:36:35AM +0100, Sean Young wrote: > On Sat, Jul 20, 2019 at 11:43:02AM +0530, Vandana BN wrote: > > Syzbot reported global-out-of-bounds Read in dvb_pll_attach, while > > accessing id[dvb_pll_devcount], because dvb_pll_devcount was 65, > > that is more than size of 'id' wh

Re: [PATCH v2] media:dvb-frontends:Remove dvb_pll_devcount and id module parameters.

2019-07-23 Thread Sean Young
On Sat, Jul 20, 2019 at 11:43:02AM +0530, Vandana BN wrote: > Syzbot reported global-out-of-bounds Read in dvb_pll_attach, while > accessing id[dvb_pll_devcount], because dvb_pll_devcount was 65, > that is more than size of 'id' which is DVB_PLL_MAX(64). > > Fix would be to check if DVB_PLL_MAX de

[PATCH v2] media:dvb-frontends:Remove dvb_pll_devcount and id module parameters.

2019-07-19 Thread Vandana BN
Syzbot reported global-out-of-bounds Read in dvb_pll_attach, while accessing id[dvb_pll_devcount], because dvb_pll_devcount was 65, that is more than size of 'id' which is DVB_PLL_MAX(64). Fix would be to check if DVB_PLL_MAX devices are attached and if so return NULL from dvb_pll_attach(). But th