Re: [PATCH v2] memory: brcmstb_dpfe: Fix memory leak

2020-08-20 Thread Krzysztof Kozlowski
On Thu, Aug 20, 2020 at 06:21:18PM +0100, Alex Dewar wrote: > In brcmstb_dpfe_download_firmware(), memory is allocated to variable fw by > firmware_request_nowarn(), but never released. Fix up to release fw on > all return paths. > > Signed-off-by: Alex Dewar > --- > v2: Don't assign ret unnecess

Re: [PATCH v2] memory: brcmstb_dpfe: Fix memory leak

2020-08-20 Thread Florian Fainelli
On 8/20/20 10:21 AM, Alex Dewar wrote: > In brcmstb_dpfe_download_firmware(), memory is allocated to variable fw by > firmware_request_nowarn(), but never released. Fix up to release fw on > all return paths. > > Signed-off-by: Alex Dewar Acked-by: Florian Fainelli Fixes: 2f330caff577 ("memory:

Re: [PATCH v2] memory: brcmstb_dpfe: Fix memory leak

2020-08-20 Thread Markus Mayer
On Thu, 20 Aug 2020 at 10:21, Alex Dewar wrote: > > In brcmstb_dpfe_download_firmware(), memory is allocated to variable fw by > firmware_request_nowarn(), but never released. Fix up to release fw on > all return paths. Thanks for the fix! Acked-by: Markus Mayer > Signed-off-by: Alex Dewar >

[PATCH v2] memory: brcmstb_dpfe: Fix memory leak

2020-08-20 Thread Alex Dewar
In brcmstb_dpfe_download_firmware(), memory is allocated to variable fw by firmware_request_nowarn(), but never released. Fix up to release fw on all return paths. Signed-off-by: Alex Dewar --- v2: Don't assign ret unnecessarily (Krzysztof) --- drivers/memory/brcmstb_dpfe.c | 16 ++--