Re: [PATCH v2] mfd: intel-lpss: use devm_ioremap_uc for MMIO

2019-10-09 Thread Andy Shevchenko
On Wed, Oct 9, 2019 at 12:09 AM GMAIL wrote: > > I think that's a fair point. Sorry for not noticing it earlier. > > > On Tue, Oct 8, 2019, 6:12 PM Andy Shevchenko < > > andriy.shevche...@linux.intel.com> wrote: > > > Maybe we can even split this to two patches? > > I assume splitting means one

Re: [PATCH v2] mfd: intel-lpss: use devm_ioremap_uc for MMIO

2019-10-08 Thread GMAIL
I think that's a fair point. Sorry for not noticing it earlier. > On Tue, Oct 8, 2019, 6:12 PM Andy Shevchenko < > andriy.shevche...@linux.intel.com> wrote: > > Maybe we can even split this to two patches? I assume splitting means one to add devm_ioremap_uc and one to use it for intel-lpss-pci.

Re: [PATCH v2] mfd: intel-lpss: use devm_ioremap_uc for MMIO

2019-10-08 Thread Andy Shevchenko
On Tue, Oct 08, 2019 at 03:16:28PM +, Luis Chamberlain wrote: > On Mon, Oct 07, 2019 at 12:42:31PM -0600, Tuowen Zhao wrote: > > +EXPORT_SYMBOL(devm_ioremap_uc); > > EXPORT_SYMBOL_GPL() would be my preference. Maybe we can even split this to two patches? -- With Best Regards, Andy

Re: [PATCH v2] mfd: intel-lpss: use devm_ioremap_uc for MMIO

2019-10-08 Thread Luis Chamberlain
On Mon, Oct 07, 2019 at 12:42:31PM -0600, Tuowen Zhao wrote: > +EXPORT_SYMBOL(devm_ioremap_uc); EXPORT_SYMBOL_GPL() would be my preference. Luis

Re: [PATCH v2] mfd: intel-lpss: use devm_ioremap_uc for MMIO

2019-10-08 Thread Andy Shevchenko
On Mon, Oct 07, 2019 at 12:42:31PM -0600, Tuowen Zhao wrote: > Some BIOS erroneously specifies write-combining BAR for intel-lpss-pci > in MTRR. This will cause the system to hang during boot. If possible, > this bug could be corrected with a firmware update. > > This patch adds devm_ioremap_uc

Re: [PATCH v2] mfd: intel-lpss: use devm_ioremap_uc for MMIO

2019-10-08 Thread Mika Westerberg
On Mon, Oct 07, 2019 at 12:42:31PM -0600, Tuowen Zhao wrote: > Some BIOS erroneously specifies write-combining BAR for intel-lpss-pci > in MTRR. This will cause the system to hang during boot. If possible, > this bug could be corrected with a firmware update. > > This patch adds devm_ioremap_uc

Re: [PATCH v2] mfd: intel-lpss: use devm_ioremap_uc for MMIO

2019-10-07 Thread AceLan Kao
Confirmed the patch works well on Dell XPS 7390 2-in-1 machine. Tested-by: AceLan Kao Tuowen Zhao 於 2019年10月8日 週二 上午2:43寫道： > > Some BIOS erroneously specifies write-combining BAR for intel-lpss-pci > in MTRR. This will cause the system to hang during boot. If possible, > this bug could be

[PATCH v2] mfd: intel-lpss: use devm_ioremap_uc for MMIO

2019-10-07 Thread Tuowen Zhao
Some BIOS erroneously specifies write-combining BAR for intel-lpss-pci in MTRR. This will cause the system to hang during boot. If possible, this bug could be corrected with a firmware update. This patch adds devm_ioremap_uc as a new managed wrapper to ioremap_uc and with it overwrite the MTRR