Re: [PATCH v2] misc: pvpanic: introduce device capability

2021-01-08 Thread Paolo Bonzini
On 08/01/21 12:28, Greg KH wrote: static void __iomem *base; +static unsigned int capability = PVPANIC_PANICKED | PVPANIC_CRASH_LOADED; +module_param(capability, uint, 0444); +MODULE_PARM_DESC(capability, "capability of pvpanic device"); This is not the 1990's, please do not add new module

Re: [PATCH v2] misc: pvpanic: introduce device capability

2021-01-08 Thread Greg KH
On Fri, Jan 08, 2021 at 07:17:10PM +0800, zhenwei pi wrote: > According to pvpanic spec: > https://git.qemu.org/?p=qemu.git;a=blob_plain;f=docs/specs/pvpanic.txt > > The guest should determine pvpanic capability by RDPT, so initialize > capability during device probing. There is no need to

Re: [PATCH v2] misc: pvpanic: introduce device capability

2021-01-08 Thread Greg KH
On Fri, Jan 08, 2021 at 07:17:10PM +0800, zhenwei pi wrote: > According to pvpanic spec: > https://git.qemu.org/?p=qemu.git;a=blob_plain;f=docs/specs/pvpanic.txt > > The guest should determine pvpanic capability by RDPT, so initialize > capability during device probing. There is no need to

[PATCH v2] misc: pvpanic: introduce device capability

2021-01-08 Thread zhenwei pi
According to pvpanic spec: https://git.qemu.org/?p=qemu.git;a=blob_plain;f=docs/specs/pvpanic.txt The guest should determine pvpanic capability by RDPT, so initialize capability during device probing. There is no need to register panic notifier callback function if no events supported. Before