Re: [PATCH v2] mm/balloon_compaction: avoid duplicate page removal

2019-07-18 Thread Michael S. Tsirkin
On Thu, Jul 18, 2019 at 04:42:50PM -0400, Michael S. Tsirkin wrote: > On Thu, Jul 18, 2019 at 01:36:26PM -0700, Andrew Morton wrote: > > On Thu, 18 Jul 2019 08:26:11 -0400 "Michael S. Tsirkin" > > wrote: > > > > > On Thu, Jul 18, 2019 at 05:27:20PM +0800, Wei Wang wrote: > > > > Fixes: 418a3ab1e

Re: [PATCH v2] mm/balloon_compaction: avoid duplicate page removal

2019-07-18 Thread Michael S. Tsirkin
On Thu, Jul 18, 2019 at 01:36:26PM -0700, Andrew Morton wrote: > On Thu, 18 Jul 2019 08:26:11 -0400 "Michael S. Tsirkin" > wrote: > > > On Thu, Jul 18, 2019 at 05:27:20PM +0800, Wei Wang wrote: > > > Fixes: 418a3ab1e778 (mm/balloon_compaction: List interfaces) > > > > > > A #GP is reported in t

Re: [PATCH v2] mm/balloon_compaction: avoid duplicate page removal

2019-07-18 Thread Andrew Morton
On Thu, 18 Jul 2019 08:26:11 -0400 "Michael S. Tsirkin" wrote: > On Thu, Jul 18, 2019 at 05:27:20PM +0800, Wei Wang wrote: > > Fixes: 418a3ab1e778 (mm/balloon_compaction: List interfaces) > > > > A #GP is reported in the guest when requesting balloon inflation via > > virtio-balloon. The reason

Re: [PATCH v2] mm/balloon_compaction: avoid duplicate page removal

2019-07-18 Thread Nadav Amit
> On Jul 18, 2019, at 5:26 AM, Michael S. Tsirkin wrote: > > On Thu, Jul 18, 2019 at 05:27:20PM +0800, Wei Wang wrote: >> Fixes: 418a3ab1e778 (mm/balloon_compaction: List interfaces) >> >> A #GP is reported in the guest when requesting balloon inflation via >> virtio-balloon. The reason is that

Re: [PATCH v2] mm/balloon_compaction: avoid duplicate page removal

2019-07-18 Thread Michael S. Tsirkin
On Thu, Jul 18, 2019 at 05:27:20PM +0800, Wei Wang wrote: > Fixes: 418a3ab1e778 (mm/balloon_compaction: List interfaces) > > A #GP is reported in the guest when requesting balloon inflation via > virtio-balloon. The reason is that the virtio-balloon driver has > removed the page from its internal

Re: [PATCH v2] mm/balloon_compaction: avoid duplicate page removal

2019-07-18 Thread Michael S. Tsirkin
OK almost. Bunch of typos but I fixed them. Thanks! On Thu, Jul 18, 2019 at 05:27:20PM +0800, Wei Wang wrote: > Fixes: 418a3ab1e778 (mm/balloon_compaction: List interfaces) > > A #GP is reported in the guest when requesting balloon inflation via > virtio-balloon. The reason is that the virtio-bal

[PATCH v2] mm/balloon_compaction: avoid duplicate page removal

2019-07-18 Thread Wei Wang
Fixes: 418a3ab1e778 (mm/balloon_compaction: List interfaces) A #GP is reported in the guest when requesting balloon inflation via virtio-balloon. The reason is that the virtio-balloon driver has removed the page from its internal page list (via balloon_page_pop), but balloon_page_enqueue_one also