Re: [PATCH v2] mm/compaction: Rename 'start_pfn' to 'iteration_start_pfn' in compact_zone()

2020-10-19 Thread Xu, Yanfei
On 10/19/20 6:48 PM, Vlastimil Babka wrote: On 10/19/20 12:29 PM, Xu, Yanfei wrote: On 10/19/20 5:40 PM, Vlastimil Babka wrote: On 10/19/20 10:36 AM, yanfei...@windriver.com wrote: From: Yanfei Xu There are two 'start_pfn' declared in compact_zone() which have different meaning. Rename

Re: [PATCH v2] mm/compaction: Rename 'start_pfn' to 'iteration_start_pfn' in compact_zone()

2020-10-19 Thread Vlastimil Babka
On 10/19/20 12:29 PM, Xu, Yanfei wrote: On 10/19/20 5:40 PM, Vlastimil Babka wrote: On 10/19/20 10:36 AM, yanfei...@windriver.com wrote: From: Yanfei Xu There are two 'start_pfn' declared in compact_zone() which have different meaning. Rename the second one to 'iteration_start_pfn' to

Re: [PATCH v2] mm/compaction: Rename 'start_pfn' to 'iteration_start_pfn' in compact_zone()

2020-10-19 Thread Xu, Yanfei
On 10/19/20 5:40 PM, Vlastimil Babka wrote: On 10/19/20 10:36 AM, yanfei...@windriver.com wrote: From: Yanfei Xu There are two 'start_pfn' declared in compact_zone() which have different meaning. Rename the second one to 'iteration_start_pfn' to prevent trace_mm_compaction_end() from

Re: [PATCH v2] mm/compaction: Rename 'start_pfn' to 'iteration_start_pfn' in compact_zone()

2020-10-19 Thread Vlastimil Babka
On 10/19/20 10:36 AM, yanfei...@windriver.com wrote: From: Yanfei Xu There are two 'start_pfn' declared in compact_zone() which have different meaning. Rename the second one to 'iteration_start_pfn' to prevent trace_mm_compaction_end() from tracing an undesirable value. "to prevent

Re: [PATCH v2] mm/compaction: Rename 'start_pfn' to 'iteration_start_pfn' in compact_zone()

2020-10-19 Thread Pankaj Gupta
> From: Yanfei Xu > > There are two 'start_pfn' declared in compact_zone() which have > different meaning. Rename the second one to 'iteration_start_pfn' > to prevent trace_mm_compaction_end() from tracing an undesirable > value. > > BTW, remove an useless semicolon. > > Acked-by: David

[PATCH v2] mm/compaction: Rename 'start_pfn' to 'iteration_start_pfn' in compact_zone()

2020-10-19 Thread yanfei . xu
From: Yanfei Xu There are two 'start_pfn' declared in compact_zone() which have different meaning. Rename the second one to 'iteration_start_pfn' to prevent trace_mm_compaction_end() from tracing an undesirable value. BTW, remove an useless semicolon. Acked-by: David Hildenbrand Acked-by: