Re: [PATCH v2] mm/hotplug: fix offline undo_isolate_page_range()

2019-03-14 Thread Michal Hocko
On Thu 14-03-19 09:09:22, Oscar Salvador wrote: > On Wed, Mar 13, 2019 at 10:31:33AM -0400, Qian Cai wrote: > > Also, after calling the "useless" undo_isolate_page_range() here, it > > reaches the point of no returning by notifying MEM_OFFLINE. Those pages > > will be marked as MIGRATE_MOVABLE agai

Re: [PATCH v2] mm/hotplug: fix offline undo_isolate_page_range()

2019-03-14 Thread Oscar Salvador
On Wed, Mar 13, 2019 at 10:31:33AM -0400, Qian Cai wrote: > The commit f1dd2cd13c4b ("mm, memory_hotplug: do not associate hotadded > memory to zones until online") introduced move_pfn_range_to_zone() which > calls memmap_init_zone() during onlining a memory block. > memmap_init_zone() will reset p

Re: [PATCH v2] mm/hotplug: fix offline undo_isolate_page_range()

2019-03-14 Thread Oscar Salvador
On Wed, Mar 13, 2019 at 10:31:33AM -0400, Qian Cai wrote: > Also, after calling the "useless" undo_isolate_page_range() here, it > reaches the point of no returning by notifying MEM_OFFLINE. Those pages > will be marked as MIGRATE_MOVABLE again once onlining. The only thing > left to do is to decre

Re: [PATCH v2] mm/hotplug: fix offline undo_isolate_page_range()

2019-03-14 Thread Michal Hocko
On Wed 13-03-19 10:31:33, Qian Cai wrote: > The commit f1dd2cd13c4b ("mm, memory_hotplug: do not associate hotadded > memory to zones until online") introduced move_pfn_range_to_zone() which > calls memmap_init_zone() during onlining a memory block. > memmap_init_zone() will reset pagetype flags an

[PATCH v2] mm/hotplug: fix offline undo_isolate_page_range()

2019-03-13 Thread Qian Cai
The commit f1dd2cd13c4b ("mm, memory_hotplug: do not associate hotadded memory to zones until online") introduced move_pfn_range_to_zone() which calls memmap_init_zone() during onlining a memory block. memmap_init_zone() will reset pagetype flags and makes migrate type to be MOVABLE. However, in _