Re: [PATCH v2] mm/memory_hotplug: drain per-cpu pages again during memory offline

2020-09-04 Thread Michal Hocko
On Thu 03-09-20 12:31:36, Andrew Morton wrote: > On Thu, 3 Sep 2020 19:36:26 +0200 David Hildenbrand wrote: > > > (still on vacation, back next week on Tuesday) > > > > I didn't look into discussions in v1, but to me this looks like we are > > trying to hide an actual bug by implementing hacks

Re: [PATCH v2] mm/memory_hotplug: drain per-cpu pages again during memory offline

2020-09-03 Thread David Hildenbrand
> Am 03.09.2020 um 21:31 schrieb Andrew Morton : > > On Thu, 3 Sep 2020 19:36:26 +0200 David Hildenbrand wrote: > >> (still on vacation, back next week on Tuesday) >> >> I didn't look into discussions in v1, but to me this looks like we are >> trying to hide an actual bug by implementing

Re: [PATCH v2] mm/memory_hotplug: drain per-cpu pages again during memory offline

2020-09-03 Thread Andrew Morton
On Thu, 3 Sep 2020 19:36:26 +0200 David Hildenbrand wrote: > (still on vacation, back next week on Tuesday) > > I didn't look into discussions in v1, but to me this looks like we are > trying to hide an actual bug by implementing hacks in the caller > (repeated calls to drain_all_pages()). What

Re: [PATCH v2] mm/memory_hotplug: drain per-cpu pages again during memory offline

2020-09-03 Thread Pavel Tatashin
On Thu, Sep 3, 2020 at 1:36 PM David Hildenbrand wrote: > > On 03.09.20 16:00, Pavel Tatashin wrote: > > There is a race during page offline that can lead to infinite loop: > > a page never ends up on a buddy list and __offline_pages() keeps > > retrying infinitely or until a termination signal

Re: [PATCH v2] mm/memory_hotplug: drain per-cpu pages again during memory offline

2020-09-03 Thread David Hildenbrand
On 03.09.20 16:00, Pavel Tatashin wrote: > There is a race during page offline that can lead to infinite loop: > a page never ends up on a buddy list and __offline_pages() keeps > retrying infinitely or until a termination signal is received. > > Thread#1 - a new process: > > load_elf_binary >

[PATCH v2] mm/memory_hotplug: drain per-cpu pages again during memory offline

2020-09-03 Thread Pavel Tatashin
There is a race during page offline that can lead to infinite loop: a page never ends up on a buddy list and __offline_pages() keeps retrying infinitely or until a termination signal is received. Thread#1 - a new process: load_elf_binary begin_new_exec exec_mmap mmput exit_mmap