Re: [PATCH v2] mm/slub: introduce SLAB_WARN_ON_ERROR

2019-01-29 Thread Miles Chen
On Tue, 2019-01-29 at 19:46 +, Christopher Lameter wrote: > On Tue, 29 Jan 2019, Miles Chen wrote: > > > a) classic slub issue. e.g., use-after-free, redzone overwritten. It's > > more efficient to report a issue as soon as slub detects it. (comparing > > to monitor the log, set a breakpoint,

Re: [PATCH v2] mm/slub: introduce SLAB_WARN_ON_ERROR

2019-01-29 Thread Christopher Lameter
On Tue, 29 Jan 2019, Miles Chen wrote: > a) classic slub issue. e.g., use-after-free, redzone overwritten. It's > more efficient to report a issue as soon as slub detects it. (comparing > to monitor the log, set a breakpoint, and re-produce the issue). With > the coredump file, we can analyze the

Re: [PATCH v2] mm/slub: introduce SLAB_WARN_ON_ERROR

2019-01-28 Thread Miles Chen
On Tue, 2019-01-29 at 05:46 +, Christopher Lameter wrote: > On Mon, 28 Jan 2019, Andrew Morton wrote: > > > > When debugging slab errors in slub.c, sometimes we have to trigger > > > a panic in order to get the coredump file. Add a debug option > > > SLAB_WARN_ON_ERROR to toggle WARN_ON()

Re: [PATCH v2] mm/slub: introduce SLAB_WARN_ON_ERROR

2019-01-28 Thread Christopher Lameter
On Mon, 28 Jan 2019, Andrew Morton wrote: > > When debugging slab errors in slub.c, sometimes we have to trigger > > a panic in order to get the coredump file. Add a debug option > > SLAB_WARN_ON_ERROR to toggle WARN_ON() when the option is set. > > > > Change since v1: > > 1. Add a special debug

Re: [PATCH v2] mm/slub: introduce SLAB_WARN_ON_ERROR

2019-01-28 Thread Miles Chen
On Mon, 2019-01-28 at 17:41 -0800, David Rientjes wrote: > On Thu, 24 Jan 2019, miles.c...@mediatek.com wrote: > > > From: Miles Chen > > > > When debugging slab errors in slub.c, sometimes we have to trigger > > a panic in order to get the coredump file. Add a debug option > >

Re: [PATCH v2] mm/slub: introduce SLAB_WARN_ON_ERROR

2019-01-28 Thread David Rientjes
On Thu, 24 Jan 2019, miles.c...@mediatek.com wrote: > From: Miles Chen > > When debugging slab errors in slub.c, sometimes we have to trigger > a panic in order to get the coredump file. Add a debug option > SLAB_WARN_ON_ERROR to toggle WARN_ON() when the option is set. > Wouldn't it be

Re: [PATCH v2] mm/slub: introduce SLAB_WARN_ON_ERROR

2019-01-28 Thread Andrew Morton
On Thu, 24 Jan 2019 15:00:23 +0800 wrote: > From: Miles Chen > > When debugging slab errors in slub.c, sometimes we have to trigger > a panic in order to get the coredump file. Add a debug option > SLAB_WARN_ON_ERROR to toggle WARN_ON() when the option is set. > > Change since v1: > 1. Add a

[PATCH v2] mm/slub: introduce SLAB_WARN_ON_ERROR

2019-01-23 Thread miles.chen
From: Miles Chen When debugging slab errors in slub.c, sometimes we have to trigger a panic in order to get the coredump file. Add a debug option SLAB_WARN_ON_ERROR to toggle WARN_ON() when the option is set. Change since v1: 1. Add a special debug option SLAB_WARN_ON_ERROR and toggle WARN_ON()