Re: [PATCH v2] mm/swap.c: make functions and their kernel-doc agree

2018-01-31 Thread Michal Hocko
On Tue 30-01-18 23:58:48, Matthew Wilcox wrote: > On Tue, Jan 30, 2018 at 01:34:00PM +0100, Michal Hocko wrote: > > On Mon 29-01-18 16:43:55, Randy Dunlap wrote: > > > - for function pagevec_lookup_entries(), change the function parameter > > > name from nr_pages to nr_entries since that is more

Re: [PATCH v2] mm/swap.c: make functions and their kernel-doc agree

2018-01-31 Thread Michal Hocko
On Tue 30-01-18 23:58:48, Matthew Wilcox wrote: > On Tue, Jan 30, 2018 at 01:34:00PM +0100, Michal Hocko wrote: > > On Mon 29-01-18 16:43:55, Randy Dunlap wrote: > > > - for function pagevec_lookup_entries(), change the function parameter > > > name from nr_pages to nr_entries since that is more

Re: [PATCH v2] mm/swap.c: make functions and their kernel-doc agree

2018-01-30 Thread Matthew Wilcox
On Tue, Jan 30, 2018 at 01:34:00PM +0100, Michal Hocko wrote: > On Mon 29-01-18 16:43:55, Randy Dunlap wrote: > > - for function pagevec_lookup_entries(), change the function parameter > > name from nr_pages to nr_entries since that is more descriptive of > > what the parameter actually is and

Re: [PATCH v2] mm/swap.c: make functions and their kernel-doc agree

2018-01-30 Thread Matthew Wilcox
On Tue, Jan 30, 2018 at 01:34:00PM +0100, Michal Hocko wrote: > On Mon 29-01-18 16:43:55, Randy Dunlap wrote: > > - for function pagevec_lookup_entries(), change the function parameter > > name from nr_pages to nr_entries since that is more descriptive of > > what the parameter actually is and

Re: [PATCH v2] mm/swap.c: make functions and their kernel-doc agree

2018-01-30 Thread Randy Dunlap
On 01/30/2018 04:34 AM, Michal Hocko wrote: > On Mon 29-01-18 16:43:55, Randy Dunlap wrote: >> From: Randy Dunlap >> >> Fix some basic kernel-doc notation in mm/swap.c: >> - for function lru_cache_add_anon(), make its kernel-doc function name >> match its function name

Re: [PATCH v2] mm/swap.c: make functions and their kernel-doc agree

2018-01-30 Thread Randy Dunlap
On 01/30/2018 04:34 AM, Michal Hocko wrote: > On Mon 29-01-18 16:43:55, Randy Dunlap wrote: >> From: Randy Dunlap >> >> Fix some basic kernel-doc notation in mm/swap.c: >> - for function lru_cache_add_anon(), make its kernel-doc function name >> match its function name and change colon to

Re: [PATCH v2] mm/swap.c: make functions and their kernel-doc agree

2018-01-30 Thread Michal Hocko
On Mon 29-01-18 16:43:55, Randy Dunlap wrote: > From: Randy Dunlap > > Fix some basic kernel-doc notation in mm/swap.c: > - for function lru_cache_add_anon(), make its kernel-doc function name > match its function name and change colon to hyphen following the >

Re: [PATCH v2] mm/swap.c: make functions and their kernel-doc agree

2018-01-30 Thread Michal Hocko
On Mon 29-01-18 16:43:55, Randy Dunlap wrote: > From: Randy Dunlap > > Fix some basic kernel-doc notation in mm/swap.c: > - for function lru_cache_add_anon(), make its kernel-doc function name > match its function name and change colon to hyphen following the > function name This is pretty

[PATCH v2] mm/swap.c: make functions and their kernel-doc agree

2018-01-29 Thread Randy Dunlap
From: Randy Dunlap Fix some basic kernel-doc notation in mm/swap.c: - for function lru_cache_add_anon(), make its kernel-doc function name match its function name and change colon to hyphen following the function name - for function pagevec_lookup_entries(), change the

[PATCH v2] mm/swap.c: make functions and their kernel-doc agree

2018-01-29 Thread Randy Dunlap
From: Randy Dunlap Fix some basic kernel-doc notation in mm/swap.c: - for function lru_cache_add_anon(), make its kernel-doc function name match its function name and change colon to hyphen following the function name - for function pagevec_lookup_entries(), change the function parameter