Re: [PATCH v2] mm: Add SLUB free list pointer obfuscation

2017-07-05 Thread Kees Cook
On Wed, Jul 5, 2017 at 4:39 PM, Andrew Morton wrote: > On Thu, 22 Jun 2017 18:50:10 -0700 Kees Cook wrote: > >> This SLUB free list pointer obfuscation code is modified from Brad >> Spengler/PaX Team's code in the last public patch of grsecurity/PaX based >> on my understanding of the code. Chang

Re: [PATCH v2] mm: Add SLUB free list pointer obfuscation

2017-07-05 Thread Andrew Morton
On Thu, 22 Jun 2017 18:50:10 -0700 Kees Cook wrote: > This SLUB free list pointer obfuscation code is modified from Brad > Spengler/PaX Team's code in the last public patch of grsecurity/PaX based > on my understanding of the code. Changes or omissions from the original > code are mine and don't

Re: [kernel-hardening] Re: [PATCH v2] mm: Add SLUB free list pointer obfuscation

2017-07-05 Thread Kees Cook
On Thu, Jun 29, 2017 at 10:56 AM, Tycho Andersen wrote: > On Thu, Jun 29, 2017 at 01:54:13PM -0400, Rik van Riel wrote: >> On Thu, 2017-06-29 at 10:47 -0700, Kees Cook wrote: >> > On Thu, Jun 29, 2017 at 10:05 AM, Christoph Lameter >> > wrote: >> > > On Sun, 25 Jun 2017, Kees Cook wrote: >> > > >

Re: [kernel-hardening] Re: [PATCH v2] mm: Add SLUB free list pointer obfuscation

2017-06-29 Thread Tycho Andersen
On Thu, Jun 29, 2017 at 01:54:13PM -0400, Rik van Riel wrote: > On Thu, 2017-06-29 at 10:47 -0700, Kees Cook wrote: > > On Thu, Jun 29, 2017 at 10:05 AM, Christoph Lameter > > wrote: > > > On Sun, 25 Jun 2017, Kees Cook wrote: > > > > > > > The difference gets lost in the noise, but if the above

Re: [PATCH v2] mm: Add SLUB free list pointer obfuscation

2017-06-29 Thread Rik van Riel
On Thu, 2017-06-29 at 10:47 -0700, Kees Cook wrote: > On Thu, Jun 29, 2017 at 10:05 AM, Christoph Lameter > wrote: > > On Sun, 25 Jun 2017, Kees Cook wrote: > > > > > The difference gets lost in the noise, but if the above is > > > sensible, > > > it's 0.07% slower. ;) > > > > Hmmm... These diff

Re: [PATCH v2] mm: Add SLUB free list pointer obfuscation

2017-06-29 Thread Kees Cook
On Thu, Jun 29, 2017 at 10:05 AM, Christoph Lameter wrote: > On Sun, 25 Jun 2017, Kees Cook wrote: > >> The difference gets lost in the noise, but if the above is sensible, >> it's 0.07% slower. ;) > > Hmmm... These differences add up. Also in a repetative benchmark like that > you do not see the

Re: [PATCH v2] mm: Add SLUB free list pointer obfuscation

2017-06-29 Thread Christoph Lameter
On Sun, 25 Jun 2017, Kees Cook wrote: > The difference gets lost in the noise, but if the above is sensible, > it's 0.07% slower. ;) Hmmm... These differences add up. Also in a repetative benchmark like that you do not see the impact that the additional cacheline use in the cpu cache has on large

Re: [PATCH v2] mm: Add SLUB free list pointer obfuscation

2017-06-25 Thread Kees Cook
On Thu, Jun 22, 2017 at 6:50 PM, Kees Cook wrote: > This SLUB free list pointer obfuscation code is modified from Brad > Spengler/PaX Team's code in the last public patch of grsecurity/PaX based > on my understanding of the code. Changes or omissions from the original > code are mine and don't ref

[PATCH v2] mm: Add SLUB free list pointer obfuscation

2017-06-22 Thread Kees Cook
This SLUB free list pointer obfuscation code is modified from Brad Spengler/PaX Team's code in the last public patch of grsecurity/PaX based on my understanding of the code. Changes or omissions from the original code are mine and don't reflect the original grsecurity/PaX code. This adds a per-cac