Re: [PATCH v2] mm: Respect FOLL_FORCE/FOLL_COW for thp

2017-01-10 Thread David Rientjes
On Thu, 5 Jan 2017, Keno Fischer wrote: > In 19be0eaff ("mm: remove gup_flags FOLL_WRITE games from > __get_user_pages()"), > the mm code was changed from unsetting FOLL_WRITE after a COW was resolved to > setting the (newly introduced) FOLL_COW instead. Simultaneously, the check in > gup.c was u

Re: [PATCH v2] mm: Respect FOLL_FORCE/FOLL_COW for thp

2017-01-10 Thread Michal Hocko
On Tue 10-01-17 15:20:45, Kirill A. Shutemov wrote: > On Tue, Jan 10, 2017 at 10:29:10AM +0100, Michal Hocko wrote: > > On Fri 06-01-17 11:18:44, Kirill A. Shutemov wrote: > > > On Thu, Jan 05, 2017 at 08:50:25PM -0500, Keno Fischer wrote: > > > > In 19be0eaff ("mm: remove gup_flags FOLL_WRITE game

Re: [PATCH v2] mm: Respect FOLL_FORCE/FOLL_COW for thp

2017-01-10 Thread Kirill A. Shutemov
On Tue, Jan 10, 2017 at 10:29:10AM +0100, Michal Hocko wrote: > On Fri 06-01-17 11:18:44, Kirill A. Shutemov wrote: > > On Thu, Jan 05, 2017 at 08:50:25PM -0500, Keno Fischer wrote: > > > In 19be0eaff ("mm: remove gup_flags FOLL_WRITE games from > > > __get_user_pages()"), > > > the mm code was ch

Re: [PATCH v2] mm: Respect FOLL_FORCE/FOLL_COW for thp

2017-01-10 Thread Michal Hocko
On Fri 06-01-17 11:18:44, Kirill A. Shutemov wrote: > On Thu, Jan 05, 2017 at 08:50:25PM -0500, Keno Fischer wrote: > > In 19be0eaff ("mm: remove gup_flags FOLL_WRITE games from > > __get_user_pages()"), > > the mm code was changed from unsetting FOLL_WRITE after a COW was resolved > > to > > set

Re: [PATCH v2] mm: Respect FOLL_FORCE/FOLL_COW for thp

2017-01-06 Thread Kirill A. Shutemov
On Thu, Jan 05, 2017 at 08:50:25PM -0500, Keno Fischer wrote: > In 19be0eaff ("mm: remove gup_flags FOLL_WRITE games from > __get_user_pages()"), > the mm code was changed from unsetting FOLL_WRITE after a COW was resolved to > setting the (newly introduced) FOLL_COW instead. Simultaneously, the c

[PATCH v2] mm: Respect FOLL_FORCE/FOLL_COW for thp

2017-01-05 Thread Keno Fischer
In 19be0eaff ("mm: remove gup_flags FOLL_WRITE games from __get_user_pages()"), the mm code was changed from unsetting FOLL_WRITE after a COW was resolved to setting the (newly introduced) FOLL_COW instead. Simultaneously, the check in gup.c was updated to still allow writes with FOLL_FORCE set if