On Thu, 2012-08-09 at 14:08 -0500, Christoph Lameter (Open Source)
wrote:
> On Thu, 9 Aug 2012, Shuah Khan wrote:
>
> > Moving these checks into kmem_cache_sanity_check() would mean return
> > path handling will change. The first block of sanity checks for name,
> > and size etc. are done before
On Thu, 9 Aug 2012, Shuah Khan wrote:
> Moving these checks into kmem_cache_sanity_check() would mean return
> path handling will change. The first block of sanity checks for name,
> and size etc. are done before holding the slab_mutex and the second
> block that checks the slab lists is done
On Thu, 2012-08-09 at 09:13 -0500, Christoph Lameter (Open Source)
wrote:
> On Mon, 6 Aug 2012, Shuah Khan wrote:
>
> > +#ifdef CONFIG_DEBUG_VM
> > +static int kmem_cache_sanity_check(const char *name, size_t size)
>
> Why do we pass "size" in? AFAICT there is no need to.
It is an oversight on
On Mon, 6 Aug 2012, Shuah Khan wrote:
> +#ifdef CONFIG_DEBUG_VM
> +static int kmem_cache_sanity_check(const char *name, size_t size)
Why do we pass "size" in? AFAICT there is no need to.
> @@ -53,48 +93,17 @@ struct kmem_cache *kmem_cache_create(const char *name,
> size_t size, size_t align
>
On Mon, 2012-08-06 at 15:13 -0600, Shuah Khan wrote:
> kmem_cache_create() does cache integrity checks when CONFIG_DEBUG_VM
> is defined. These checks interspersed with the regular code path has
> lead to compile time warnings when compiled without CONFIG_DEBUG_VM
> defined. Restructuring the code
On Mon, 2012-08-06 at 15:13 -0600, Shuah Khan wrote:
kmem_cache_create() does cache integrity checks when CONFIG_DEBUG_VM
is defined. These checks interspersed with the regular code path has
lead to compile time warnings when compiled without CONFIG_DEBUG_VM
defined. Restructuring the code to
On Mon, 6 Aug 2012, Shuah Khan wrote:
+#ifdef CONFIG_DEBUG_VM
+static int kmem_cache_sanity_check(const char *name, size_t size)
Why do we pass size in? AFAICT there is no need to.
@@ -53,48 +93,17 @@ struct kmem_cache *kmem_cache_create(const char *name,
size_t size, size_t align
{
On Thu, 2012-08-09 at 09:13 -0500, Christoph Lameter (Open Source)
wrote:
On Mon, 6 Aug 2012, Shuah Khan wrote:
+#ifdef CONFIG_DEBUG_VM
+static int kmem_cache_sanity_check(const char *name, size_t size)
Why do we pass size in? AFAICT there is no need to.
It is an oversight on my part.
On Thu, 9 Aug 2012, Shuah Khan wrote:
Moving these checks into kmem_cache_sanity_check() would mean return
path handling will change. The first block of sanity checks for name,
and size etc. are done before holding the slab_mutex and the second
block that checks the slab lists is done after
On Thu, 2012-08-09 at 14:08 -0500, Christoph Lameter (Open Source)
wrote:
On Thu, 9 Aug 2012, Shuah Khan wrote:
Moving these checks into kmem_cache_sanity_check() would mean return
path handling will change. The first block of sanity checks for name,
and size etc. are done before holding
kmem_cache_create() does cache integrity checks when CONFIG_DEBUG_VM
is defined. These checks interspersed with the regular code path has
lead to compile time warnings when compiled without CONFIG_DEBUG_VM
defined. Restructuring the code to move the integrity checks in to a new
function would
kmem_cache_create() does cache integrity checks when CONFIG_DEBUG_VM
is defined. These checks interspersed with the regular code path has
lead to compile time warnings when compiled without CONFIG_DEBUG_VM
defined. Restructuring the code to move the integrity checks in to a new
function would
12 matches
Mail list logo
