Re: [PATCH v2] mm: emit tracepoint when RSS changes by threshold

2019-09-05 Thread Joel Fernandes
On Thu, Sep 05, 2019 at 06:15:43PM -0700, Daniel Colascione wrote: [snip] > > > > > > > The bigger improvement with the threshold is the number of trace > > > > > > > records are > > > > > > > almost halved by using a threshold. The number of records went > > > > > > > from 4.6K to > > > > > > >

Re: [PATCH v2] mm: emit tracepoint when RSS changes by threshold

2019-09-05 Thread Daniel Colascione
On Thu, Sep 5, 2019 at 5:59 PM Joel Fernandes wrote: > On Thu, Sep 05, 2019 at 10:50:27AM -0700, Daniel Colascione wrote: > > On Thu, Sep 5, 2019 at 10:35 AM Steven Rostedt wrote: > > > On Thu, 5 Sep 2019 09:03:01 -0700 > > > Suren Baghdasaryan wrote: > > > > > > > On Thu, Sep 5, 2019 at 7:43

Re: [PATCH v2] mm: emit tracepoint when RSS changes by threshold

2019-09-05 Thread Joel Fernandes
On Thu, Sep 05, 2019 at 10:50:27AM -0700, Daniel Colascione wrote: > On Thu, Sep 5, 2019 at 10:35 AM Steven Rostedt wrote: > > On Thu, 5 Sep 2019 09:03:01 -0700 > > Suren Baghdasaryan wrote: > > > > > On Thu, Sep 5, 2019 at 7:43 AM Michal Hocko wrote: > > > > > > > > [Add Steven] > > > > > > >

Re: [PATCH v2] mm: emit tracepoint when RSS changes by threshold

2019-09-05 Thread Daniel Colascione
On Thu, Sep 5, 2019 at 3:12 PM Daniel Colascione wrote: > Basically, what I have in mind is this: Actually --- I wonder whether there's already enough power in the trigger mechanism to do this without any code changes to ftrace histograms themselves. I'm trying to think of the minimum additional

Re: [PATCH v2] mm: emit tracepoint when RSS changes by threshold

2019-09-05 Thread Daniel Colascione
On Thu, Sep 5, 2019 at 2:14 PM Tom Zanussi wrote: > > On Thu, 2019-09-05 at 13:24 -0700, Daniel Colascione wrote: > > On Thu, Sep 5, 2019 at 12:56 PM Tom Zanussi > > wrote: > > > On Thu, 2019-09-05 at 13:51 -0400, Joel Fernandes wrote: > > > > On Thu, Sep 05, 2019 at 01:47:05PM -0400, Joel

Re: [PATCH v2] mm: emit tracepoint when RSS changes by threshold

2019-09-05 Thread Tom Zanussi
On Thu, 2019-09-05 at 13:24 -0700, Daniel Colascione wrote: > On Thu, Sep 5, 2019 at 12:56 PM Tom Zanussi > wrote: > > On Thu, 2019-09-05 at 13:51 -0400, Joel Fernandes wrote: > > > On Thu, Sep 05, 2019 at 01:47:05PM -0400, Joel Fernandes wrote: > > > > On Thu, Sep 05, 2019 at 01:35:07PM -0400,

Re: [PATCH v2] mm: emit tracepoint when RSS changes by threshold

2019-09-05 Thread Tom Zanussi
Hi, On Thu, 2019-09-05 at 13:24 -0700, Daniel Colascione wrote: > On Thu, Sep 5, 2019 at 12:56 PM Tom Zanussi > wrote: > > On Thu, 2019-09-05 at 13:51 -0400, Joel Fernandes wrote: > > > On Thu, Sep 05, 2019 at 01:47:05PM -0400, Joel Fernandes wrote: > > > > On Thu, Sep 05, 2019 at 01:35:07PM

Re: [PATCH v2] mm: emit tracepoint when RSS changes by threshold

2019-09-05 Thread Daniel Colascione
On Thu, Sep 5, 2019 at 12:56 PM Tom Zanussi wrote: > On Thu, 2019-09-05 at 13:51 -0400, Joel Fernandes wrote: > > On Thu, Sep 05, 2019 at 01:47:05PM -0400, Joel Fernandes wrote: > > > On Thu, Sep 05, 2019 at 01:35:07PM -0400, Steven Rostedt wrote: > > > > > > > > > > > > [ Added Tom ] > > > > > >

Re: [PATCH v2] mm: emit tracepoint when RSS changes by threshold

2019-09-05 Thread Tom Zanussi
Hi, On Thu, 2019-09-05 at 13:51 -0400, Joel Fernandes wrote: > On Thu, Sep 05, 2019 at 01:47:05PM -0400, Joel Fernandes wrote: > > On Thu, Sep 05, 2019 at 01:35:07PM -0400, Steven Rostedt wrote: > > > > > > > > > [ Added Tom ] > > > > > > On Thu, 5 Sep 2019 09:03:01 -0700 > > > Suren

Re: [PATCH v2] mm: emit tracepoint when RSS changes by threshold

2019-09-05 Thread Joel Fernandes
On Thu, Sep 05, 2019 at 01:47:05PM -0400, Joel Fernandes wrote: > On Thu, Sep 05, 2019 at 01:35:07PM -0400, Steven Rostedt wrote: > > > > > > [ Added Tom ] > > > > On Thu, 5 Sep 2019 09:03:01 -0700 > > Suren Baghdasaryan wrote: > > > > > On Thu, Sep 5, 2019 at 7:43 AM Michal Hocko wrote: > >

Re: [PATCH v2] mm: emit tracepoint when RSS changes by threshold

2019-09-05 Thread Daniel Colascione
On Thu, Sep 5, 2019 at 10:35 AM Steven Rostedt wrote: > On Thu, 5 Sep 2019 09:03:01 -0700 > Suren Baghdasaryan wrote: > > > On Thu, Sep 5, 2019 at 7:43 AM Michal Hocko wrote: > > > > > > [Add Steven] > > > > > > On Wed 04-09-19 12:28:08, Joel Fernandes wrote: > > > > On Wed, Sep 4, 2019 at

Re: [PATCH v2] mm: emit tracepoint when RSS changes by threshold

2019-09-05 Thread Joel Fernandes
On Thu, Sep 05, 2019 at 01:35:07PM -0400, Steven Rostedt wrote: > > > [ Added Tom ] > > On Thu, 5 Sep 2019 09:03:01 -0700 > Suren Baghdasaryan wrote: > > > On Thu, Sep 5, 2019 at 7:43 AM Michal Hocko wrote: > > > > > > [Add Steven] > > > > > > On Wed 04-09-19 12:28:08, Joel Fernandes wrote:

Re: [PATCH v2] mm: emit tracepoint when RSS changes by threshold

2019-09-05 Thread Tim Murray
On Thu, Sep 5, 2019 at 9:03 AM Suren Baghdasaryan wrote: > I might misunderstand this but is the issue here actually throttling > of the sheer number of trace records or tracing large enough changes > to RSS that user might care about? Small changes happen all the time > but we are likely not

Re: [PATCH v2] mm: emit tracepoint when RSS changes by threshold

2019-09-05 Thread Suren Baghdasaryan
On Thu, Sep 5, 2019 at 10:35 AM Steven Rostedt wrote: > > > > [ Added Tom ] > > On Thu, 5 Sep 2019 09:03:01 -0700 > Suren Baghdasaryan wrote: > > > On Thu, Sep 5, 2019 at 7:43 AM Michal Hocko wrote: > > > > > > [Add Steven] > > > > > > On Wed 04-09-19 12:28:08, Joel Fernandes wrote: > > > > On

Re: [PATCH v2] mm: emit tracepoint when RSS changes by threshold

2019-09-05 Thread Steven Rostedt
[ Added Tom ] On Thu, 5 Sep 2019 09:03:01 -0700 Suren Baghdasaryan wrote: > On Thu, Sep 5, 2019 at 7:43 AM Michal Hocko wrote: > > > > [Add Steven] > > > > On Wed 04-09-19 12:28:08, Joel Fernandes wrote: > > > On Wed, Sep 4, 2019 at 11:38 AM Michal Hocko wrote: > > > > > > > > On Wed

Re: [PATCH v2] mm: emit tracepoint when RSS changes by threshold

2019-09-05 Thread Suren Baghdasaryan
On Thu, Sep 5, 2019 at 7:43 AM Michal Hocko wrote: > > [Add Steven] > > On Wed 04-09-19 12:28:08, Joel Fernandes wrote: > > On Wed, Sep 4, 2019 at 11:38 AM Michal Hocko wrote: > > > > > > On Wed 04-09-19 11:32:58, Joel Fernandes wrote: > [...] > > > > but also for reducing > > > > tracing noise.

Re: [PATCH v2] mm: emit tracepoint when RSS changes by threshold

2019-09-05 Thread Michal Hocko
[Add Steven] On Wed 04-09-19 12:28:08, Joel Fernandes wrote: > On Wed, Sep 4, 2019 at 11:38 AM Michal Hocko wrote: > > > > On Wed 04-09-19 11:32:58, Joel Fernandes wrote: [...] > > > but also for reducing > > > tracing noise. Flooding the traces makes it less useful for long traces > > > and >

Re: [PATCH v2] mm: emit tracepoint when RSS changes by threshold

2019-09-05 Thread Joel Fernandes
On Thu, Sep 05, 2019 at 04:20:10PM +0200, Michal Hocko wrote: > On Thu 05-09-19 10:14:52, Joel Fernandes wrote: > > On Thu, Sep 05, 2019 at 12:54:24PM +0200, Michal Hocko wrote: > > > On Wed 04-09-19 12:28:08, Joel Fernandes wrote: > > > > On Wed, Sep 4, 2019 at 11:38 AM Michal Hocko wrote: > > >

Re: [PATCH v2] mm: emit tracepoint when RSS changes by threshold

2019-09-05 Thread Michal Hocko
On Thu 05-09-19 10:14:52, Joel Fernandes wrote: > On Thu, Sep 05, 2019 at 12:54:24PM +0200, Michal Hocko wrote: > > On Wed 04-09-19 12:28:08, Joel Fernandes wrote: > > > On Wed, Sep 4, 2019 at 11:38 AM Michal Hocko wrote: > > > > > > > > On Wed 04-09-19 11:32:58, Joel Fernandes wrote: > > > > >

Re: [PATCH v2] mm: emit tracepoint when RSS changes by threshold

2019-09-05 Thread Joel Fernandes
On Thu, Sep 05, 2019 at 12:54:24PM +0200, Michal Hocko wrote: > On Wed 04-09-19 12:28:08, Joel Fernandes wrote: > > On Wed, Sep 4, 2019 at 11:38 AM Michal Hocko wrote: > > > > > > On Wed 04-09-19 11:32:58, Joel Fernandes wrote: > > > > On Wed, Sep 04, 2019 at 10:45:08AM +0200, Michal Hocko wrote:

Re: [PATCH v2] mm: emit tracepoint when RSS changes by threshold

2019-09-05 Thread Michal Hocko
On Wed 04-09-19 12:28:08, Joel Fernandes wrote: > On Wed, Sep 4, 2019 at 11:38 AM Michal Hocko wrote: > > > > On Wed 04-09-19 11:32:58, Joel Fernandes wrote: > > > On Wed, Sep 04, 2019 at 10:45:08AM +0200, Michal Hocko wrote: > > > > On Tue 03-09-19 16:09:05, Joel Fernandes (Google) wrote: > > >

Re: [PATCH v2] mm: emit tracepoint when RSS changes by threshold

2019-09-04 Thread sspatil
On Wed, Sep 04, 2019 at 10:15:10AM -0700, 'Daniel Colascione' via kernel-team wrote: > On Wed, Sep 4, 2019 at 7:59 AM Joel Fernandes wrote: > > > > On Tue, Sep 03, 2019 at 10:42:53PM -0700, Daniel Colascione wrote: > > > On Tue, Sep 3, 2019 at 10:15 PM Joel Fernandes > > > wrote: > > > > > > >

Re: [PATCH v2] mm: emit tracepoint when RSS changes by threshold

2019-09-04 Thread Daniel Colascione
On Wed, Sep 4, 2019 at 8:38 AM Michal Hocko wrote: > > but also for reducing > > tracing noise. Flooding the traces makes it less useful for long traces and > > post-processing of traces. IOW, the overhead reduction is a bonus. > > This is not really anything special for this tracepoint though. >

Re: [PATCH v2] mm: emit tracepoint when RSS changes by threshold

2019-09-04 Thread Daniel Colascione
On Wed, Sep 4, 2019 at 7:59 AM Joel Fernandes wrote: > > On Tue, Sep 03, 2019 at 10:42:53PM -0700, Daniel Colascione wrote: > > On Tue, Sep 3, 2019 at 10:15 PM Joel Fernandes > > wrote: > > > > > > On Tue, Sep 03, 2019 at 09:51:20PM -0700, Daniel Colascione wrote: > > > > On Tue, Sep 3, 2019 at

Re: [PATCH v2] mm: emit tracepoint when RSS changes by threshold

2019-09-04 Thread Joel Fernandes
On Wed, Sep 4, 2019 at 11:38 AM Michal Hocko wrote: > > On Wed 04-09-19 11:32:58, Joel Fernandes wrote: > > On Wed, Sep 04, 2019 at 10:45:08AM +0200, Michal Hocko wrote: > > > On Tue 03-09-19 16:09:05, Joel Fernandes (Google) wrote: > > > > Useful to track how RSS is changing per TGID to detect

Re: [PATCH v2] mm: emit tracepoint when RSS changes by threshold

2019-09-04 Thread Michal Hocko
On Wed 04-09-19 11:32:58, Joel Fernandes wrote: > On Wed, Sep 04, 2019 at 10:45:08AM +0200, Michal Hocko wrote: > > On Tue 03-09-19 16:09:05, Joel Fernandes (Google) wrote: > > > Useful to track how RSS is changing per TGID to detect spikes in RSS and > > > memory hogs. Several Android teams have

Re: [PATCH v2] mm: emit tracepoint when RSS changes by threshold

2019-09-04 Thread Joel Fernandes
On Wed, Sep 04, 2019 at 10:45:08AM +0200, Michal Hocko wrote: > On Tue 03-09-19 16:09:05, Joel Fernandes (Google) wrote: > > Useful to track how RSS is changing per TGID to detect spikes in RSS and > > memory hogs. Several Android teams have been using this patch in various > > kernel trees for

Re: [PATCH v2] mm: emit tracepoint when RSS changes by threshold

2019-09-04 Thread Joel Fernandes
On Tue, Sep 03, 2019 at 10:42:53PM -0700, Daniel Colascione wrote: > On Tue, Sep 3, 2019 at 10:15 PM Joel Fernandes wrote: > > > > On Tue, Sep 03, 2019 at 09:51:20PM -0700, Daniel Colascione wrote: > > > On Tue, Sep 3, 2019 at 9:45 PM Suren Baghdasaryan > > > wrote: > > > > > > > > On Tue, Sep

Re: [PATCH v2] mm: emit tracepoint when RSS changes by threshold

2019-09-04 Thread Michal Hocko
On Tue 03-09-19 16:09:05, Joel Fernandes (Google) wrote: > Useful to track how RSS is changing per TGID to detect spikes in RSS and > memory hogs. Several Android teams have been using this patch in various > kernel trees for half a year now. Many reported to me it is really > useful so I'm

Re: [PATCH v2] mm: emit tracepoint when RSS changes by threshold

2019-09-03 Thread Daniel Colascione
On Tue, Sep 3, 2019 at 10:15 PM Joel Fernandes wrote: > > On Tue, Sep 03, 2019 at 09:51:20PM -0700, Daniel Colascione wrote: > > On Tue, Sep 3, 2019 at 9:45 PM Suren Baghdasaryan wrote: > > > > > > On Tue, Sep 3, 2019 at 1:09 PM Joel Fernandes (Google) > > > wrote: > > > > > > > > Useful to

Re: [PATCH v2] mm: emit tracepoint when RSS changes by threshold

2019-09-03 Thread Suren Baghdasaryan
On Tue, Sep 3, 2019 at 10:02 PM Joel Fernandes wrote: > > On Tue, Sep 03, 2019 at 09:44:51PM -0700, Suren Baghdasaryan wrote: > > On Tue, Sep 3, 2019 at 1:09 PM Joel Fernandes (Google) > > wrote: > > > > > > Useful to track how RSS is changing per TGID to detect spikes in RSS and > > > memory

Re: [PATCH v2] mm: emit tracepoint when RSS changes by threshold

2019-09-03 Thread Joel Fernandes
On Tue, Sep 03, 2019 at 09:51:20PM -0700, Daniel Colascione wrote: > On Tue, Sep 3, 2019 at 9:45 PM Suren Baghdasaryan wrote: > > > > On Tue, Sep 3, 2019 at 1:09 PM Joel Fernandes (Google) > > wrote: > > > > > > Useful to track how RSS is changing per TGID to detect spikes in RSS and > > >

Re: [PATCH v2] mm: emit tracepoint when RSS changes by threshold

2019-09-03 Thread Joel Fernandes
On Tue, Sep 03, 2019 at 09:44:51PM -0700, Suren Baghdasaryan wrote: > On Tue, Sep 3, 2019 at 1:09 PM Joel Fernandes (Google) > wrote: > > > > Useful to track how RSS is changing per TGID to detect spikes in RSS and > > memory hogs. Several Android teams have been using this patch in various > >

Re: [PATCH v2] mm: emit tracepoint when RSS changes by threshold

2019-09-03 Thread Daniel Colascione
On Tue, Sep 3, 2019 at 9:45 PM Suren Baghdasaryan wrote: > > On Tue, Sep 3, 2019 at 1:09 PM Joel Fernandes (Google) > wrote: > > > > Useful to track how RSS is changing per TGID to detect spikes in RSS and > > memory hogs. Several Android teams have been using this patch in various > > kernel

Re: [PATCH v2] mm: emit tracepoint when RSS changes by threshold

2019-09-03 Thread Suren Baghdasaryan
On Tue, Sep 3, 2019 at 1:09 PM Joel Fernandes (Google) wrote: > > Useful to track how RSS is changing per TGID to detect spikes in RSS and > memory hogs. Several Android teams have been using this patch in various > kernel trees for half a year now. Many reported to me it is really > useful so

[PATCH v2] mm: emit tracepoint when RSS changes by threshold

2019-09-03 Thread Joel Fernandes (Google)
Useful to track how RSS is changing per TGID to detect spikes in RSS and memory hogs. Several Android teams have been using this patch in various kernel trees for half a year now. Many reported to me it is really useful so I'm posting it upstream. Initial patch developed by Tim Murray. Changes I