Re: [PATCH v2] mm: page_mapped: don't assume compound page is huge or THP

2019-02-18 Thread Michal Hocko
On Mon 18-02-19 14:43:58, Lars Persson wrote: > On Tue, Feb 5, 2019 at 8:14 AM Jan Stancek wrote: > > Hi, > > > > are you using THP (CONFIG_TRANSPARENT_HUGEPAGE)? > > > > The changed line should affect only THP and normal compound pages, > > so a test with THP disabled might be interesting. > > >

Re: [PATCH v2] mm: page_mapped: don't assume compound page is huge or THP

2019-02-18 Thread Lars Persson
On Tue, Feb 5, 2019 at 8:14 AM Jan Stancek wrote: > Hi, > > are you using THP (CONFIG_TRANSPARENT_HUGEPAGE)? > > The changed line should affect only THP and normal compound pages, > so a test with THP disabled might be interesting. > > > > > The breakage consists of random processes dying with SIG

Re: [PATCH v2] mm: page_mapped: don't assume compound page is huge or THP

2019-02-04 Thread Jan Stancek
- Original Message - > On Fri, Nov 30, 2018 at 1:07 PM Jan Stancek wrote: > > > > LTP proc01 testcase has been observed to rarely trigger crashes > > on arm64: > > page_mapped+0x78/0xb4 > > stable_page_flags+0x27c/0x338 > > kpageflags_read+0xfc/0x164 > > proc_reg_read+0x

Re: [PATCH v2] mm: page_mapped: don't assume compound page is huge or THP

2019-02-04 Thread Lars Persson
On Fri, Nov 30, 2018 at 1:07 PM Jan Stancek wrote: > > LTP proc01 testcase has been observed to rarely trigger crashes > on arm64: > page_mapped+0x78/0xb4 > stable_page_flags+0x27c/0x338 > kpageflags_read+0xfc/0x164 > proc_reg_read+0x7c/0xb8 > __vfs_read+0x58/0x178 > vfs_re

Re: [PATCH v2] mm: page_mapped: don't assume compound page is huge or THP

2019-01-04 Thread Andrea Arcangeli
[ CC'ed Andrew for potential inclusion in -mm ] On Fri, Nov 30, 2018 at 01:06:57PM +0100, Jan Stancek wrote: > LTP proc01 testcase has been observed to rarely trigger crashes > on arm64: > page_mapped+0x78/0xb4 > stable_page_flags+0x27c/0x338 > kpageflags_read+0xfc/0x164 > proc_reg

Re: [PATCH v2] mm: page_mapped: don't assume compound page is huge or THP

2018-12-03 Thread Kirill A. Shutemov
On Mon, Dec 03, 2018 at 11:23:58AM +0100, Laszlo Ersek wrote: > Totally uninformed side-question: > > how large can the return value of compound_order() be? MAX_ORDER? > > Apparently, MAX_ORDER can be defined as CONFIG_FORCE_MAX_ZONEORDER. > > "config FORCE_MAX_ZONEORDER" is listed in a number o

Re: [PATCH v2] mm: page_mapped: don't assume compound page is huge or THP

2018-12-03 Thread Laszlo Ersek
On 11/30/18 13:06, Jan Stancek wrote: > LTP proc01 testcase has been observed to rarely trigger crashes > on arm64: > page_mapped+0x78/0xb4 > stable_page_flags+0x27c/0x338 > kpageflags_read+0xfc/0x164 > proc_reg_read+0x7c/0xb8 > __vfs_read+0x58/0x178 > vfs_read+0x90/0x14c >

Re: [PATCH v2] mm: page_mapped: don't assume compound page is huge or THP

2018-11-30 Thread David Hildenbrand
On 30.11.18 13:06, Jan Stancek wrote: > LTP proc01 testcase has been observed to rarely trigger crashes > on arm64: > page_mapped+0x78/0xb4 > stable_page_flags+0x27c/0x338 > kpageflags_read+0xfc/0x164 > proc_reg_read+0x7c/0xb8 > __vfs_read+0x58/0x178 > vfs_read+0x90/0x14c >

Re: [PATCH v2] mm: page_mapped: don't assume compound page is huge or THP

2018-11-30 Thread Kirill A. Shutemov
On Fri, Nov 30, 2018 at 01:45:46PM +0100, Michal Hocko wrote: > On Fri 30-11-18 15:36:51, Kirill A. Shutemov wrote: > > On Fri, Nov 30, 2018 at 01:18:51PM +0100, Michal Hocko wrote: > > > On Fri 30-11-18 13:06:57, Jan Stancek wrote: > > > > LTP proc01 testcase has been observed to rarely trigger cr

Re: [PATCH v2] mm: page_mapped: don't assume compound page is huge or THP

2018-11-30 Thread Michal Hocko
On Fri 30-11-18 15:36:51, Kirill A. Shutemov wrote: > On Fri, Nov 30, 2018 at 01:18:51PM +0100, Michal Hocko wrote: > > On Fri 30-11-18 13:06:57, Jan Stancek wrote: > > > LTP proc01 testcase has been observed to rarely trigger crashes > > > on arm64: > > > page_mapped+0x78/0xb4 > > > stable

Re: [PATCH v2] mm: page_mapped: don't assume compound page is huge or THP

2018-11-30 Thread Kirill A. Shutemov
On Fri, Nov 30, 2018 at 01:18:51PM +0100, Michal Hocko wrote: > On Fri 30-11-18 13:06:57, Jan Stancek wrote: > > LTP proc01 testcase has been observed to rarely trigger crashes > > on arm64: > > page_mapped+0x78/0xb4 > > stable_page_flags+0x27c/0x338 > > kpageflags_read+0xfc/0x164 > >

Re: [PATCH v2] mm: page_mapped: don't assume compound page is huge or THP

2018-11-30 Thread Michal Hocko
On Fri 30-11-18 13:06:57, Jan Stancek wrote: > LTP proc01 testcase has been observed to rarely trigger crashes > on arm64: > page_mapped+0x78/0xb4 > stable_page_flags+0x27c/0x338 > kpageflags_read+0xfc/0x164 > proc_reg_read+0x7c/0xb8 > __vfs_read+0x58/0x178 > vfs_read+0x90/0

[PATCH v2] mm: page_mapped: don't assume compound page is huge or THP

2018-11-30 Thread Jan Stancek
LTP proc01 testcase has been observed to rarely trigger crashes on arm64: page_mapped+0x78/0xb4 stable_page_flags+0x27c/0x338 kpageflags_read+0xfc/0x164 proc_reg_read+0x7c/0xb8 __vfs_read+0x58/0x178 vfs_read+0x90/0x14c SyS_read+0x60/0xc0 Issue is that page_mapped() assu