Re: [PATCH v2] mm: remove unnecessary __get_user_pages_unlocked() calls

2016-10-27 Thread Paolo Bonzini
On 27/10/2016 02:12, Andrew Morton wrote: > > >> Subject: [PATCH v2] mm: remove unnecessary __get_user_pages_unlocked() calls > > The patch is rather misidentified. > >> virt/kvm/async_pf.c | 7 --- >> virt/kvm/kvm_main.c | 5 ++--- >> 2 file

Re: [PATCH v2] mm: remove unnecessary __get_user_pages_unlocked() calls

2016-10-27 Thread Paolo Bonzini
On 27/10/2016 11:32, Lorenzo Stoakes wrote: > On Thu, Oct 27, 2016 at 11:27:24AM +0200, Paolo Bonzini wrote: >> >> >> On 27/10/2016 02:12, Andrew Morton wrote: >>> >>> >>>> Subject: [PATCH v2] mm: remove unnecessary __get_user_pages

Re: [PATCH v2] mm: remove unnecessary __get_user_pages_unlocked() calls

2016-10-27 Thread Lorenzo Stoakes
On Thu, Oct 27, 2016 at 11:27:24AM +0200, Paolo Bonzini wrote: > > > On 27/10/2016 02:12, Andrew Morton wrote: > > > > > >> Subject: [PATCH v2] mm: remove unnecessary __get_user_pages_unlocked() > >> calls > > > > The patch is rath

Re: [PATCH v2] mm: remove unnecessary __get_user_pages_unlocked() calls

2016-10-27 Thread Lorenzo Stoakes
On Wed, Oct 26, 2016 at 05:12:07PM -0700, Andrew Morton wrote: > It's a KVM patch and should have been called "kvm: remove ...". > Possibly the KVM maintainers will miss it for this reason. > Ah, indeed, however I think given my and Michal's discussion in this thread regarding adjusting get_user_p

Re: [PATCH v2] mm: remove unnecessary __get_user_pages_unlocked() calls

2016-10-26 Thread Andrew Morton
> Subject: [PATCH v2] mm: remove unnecessary __get_user_pages_unlocked() calls The patch is rather misidentified. > virt/kvm/async_pf.c | 7 --- > virt/kvm/kvm_main.c | 5 ++--- > 2 files changed, 6 insertions(+), 6 deletions(-) It's a KVM patch and should have been ca

[PATCH v2] mm: remove unnecessary __get_user_pages_unlocked() calls

2016-10-26 Thread Lorenzo Stoakes
In hva_to_pfn_slow() we are able to replace __get_user_pages_unlocked() with get_user_pages_unlocked() since we can now pass gup_flags. In async_pf_execute() we need to pass different tsk, mm arguments so get_user_pages_remote() is the sane replacement here (having added manual acquisition and rel