Re: [PATCH v2] mm: show total hugetlb memory consumption in /proc/meminfo

2017-11-22 Thread Michal Hocko
On Tue 21-11-17 16:27:38, Mike Kravetz wrote: > On 11/21/2017 11:59 AM, Roman Gushchin wrote: [...] > > What we can do, is to rename "count" into "nr_huge_pages", like: > > > > for_each_hstate(h) { > > unsigned long nr_huge_pages = h->nr_huge_pages; > > > > total += (P

Re: [PATCH v2] mm: show total hugetlb memory consumption in /proc/meminfo

2017-11-21 Thread Mike Kravetz
On 11/21/2017 11:59 AM, Roman Gushchin wrote: > On Tue, Nov 21, 2017 at 11:19:07AM -0800, Andrew Morton wrote: >> >> Why not >> >> seq_printf(m, >> "HugePages_Total: %5lu\n" >> "HugePages_Free:%5lu\n" >> "HugePages_Rsvd:%

Re: [PATCH v2] mm: show total hugetlb memory consumption in /proc/meminfo

2017-11-21 Thread Roman Gushchin
On Tue, Nov 21, 2017 at 11:19:07AM -0800, Andrew Morton wrote: > On Tue, 21 Nov 2017 15:15:55 + Roman Gushchin wrote: > > > > > + > > > > + for_each_hstate(h) { > > > > + unsigned long count = h->nr_huge_pages; > > > > + > > > > + total += (PAGE_SIZE << huge_

Re: [PATCH v2] mm: show total hugetlb memory consumption in /proc/meminfo

2017-11-21 Thread Andrew Morton
On Tue, 21 Nov 2017 15:15:55 + Roman Gushchin wrote: > > > + > > > + for_each_hstate(h) { > > > + unsigned long count = h->nr_huge_pages; > > > + > > > + total += (PAGE_SIZE << huge_page_order(h)) * count; > > > + > > > + if (h == &default_hstate) > > > > I'm not unde

Re: [PATCH v2] mm: show total hugetlb memory consumption in /proc/meminfo

2017-11-21 Thread Roman Gushchin
On Mon, Nov 20, 2017 at 04:51:10PM -0800, Andrew Morton wrote: > On Wed, 15 Nov 2017 23:14:09 + Roman Gushchin wrote: > > > Currently we display some hugepage statistics (total, free, etc) > > in /proc/meminfo, but only for default hugepage size (e.g. 2Mb). > > > > If hugepages of different

Re: [PATCH v2] mm: show total hugetlb memory consumption in /proc/meminfo

2017-11-20 Thread Michal Hocko
On Mon 20-11-17 16:51:10, Andrew Morton wrote: > On Wed, 15 Nov 2017 23:14:09 + Roman Gushchin wrote: > > > Currently we display some hugepage statistics (total, free, etc) > > in /proc/meminfo, but only for default hugepage size (e.g. 2Mb). > > > > If hugepages of different sizes are used (

Re: [PATCH v2] mm: show total hugetlb memory consumption in /proc/meminfo

2017-11-20 Thread Mike Kravetz
On 11/20/2017 04:51 PM, Andrew Morton wrote: > On Wed, 15 Nov 2017 23:14:09 + Roman Gushchin wrote: > >> Currently we display some hugepage statistics (total, free, etc) >> in /proc/meminfo, but only for default hugepage size (e.g. 2Mb). >> >> If hugepages of different sizes are used (like 2M

Re: [PATCH v2] mm: show total hugetlb memory consumption in /proc/meminfo

2017-11-20 Thread Andrew Morton
On Wed, 15 Nov 2017 23:14:09 + Roman Gushchin wrote: > Currently we display some hugepage statistics (total, free, etc) > in /proc/meminfo, but only for default hugepage size (e.g. 2Mb). > > If hugepages of different sizes are used (like 2Mb and 1Gb on x86-64), > /proc/meminfo output can be

Re: [PATCH v2] mm: show total hugetlb memory consumption in /proc/meminfo

2017-11-17 Thread David Rientjes
On Wed, 15 Nov 2017, Roman Gushchin wrote: > Currently we display some hugepage statistics (total, free, etc) > in /proc/meminfo, but only for default hugepage size (e.g. 2Mb). > > If hugepages of different sizes are used (like 2Mb and 1Gb on x86-64), > /proc/meminfo output can be confusing, as n

Re: [PATCH v2] mm: show total hugetlb memory consumption in /proc/meminfo

2017-11-16 Thread Johannes Weiner
On Wed, Nov 15, 2017 at 11:14:09PM +, Roman Gushchin wrote: > Currently we display some hugepage statistics (total, free, etc) > in /proc/meminfo, but only for default hugepage size (e.g. 2Mb). > > If hugepages of different sizes are used (like 2Mb and 1Gb on x86-64), > /proc/meminfo output ca

Re: [PATCH v2] mm: show total hugetlb memory consumption in /proc/meminfo

2017-11-16 Thread Michal Hocko
On Wed 15-11-17 23:14:09, Roman Gushchin wrote: > Currently we display some hugepage statistics (total, free, etc) > in /proc/meminfo, but only for default hugepage size (e.g. 2Mb). > > If hugepages of different sizes are used (like 2Mb and 1Gb on x86-64), > /proc/meminfo output can be confusing,

[PATCH v2] mm: show total hugetlb memory consumption in /proc/meminfo

2017-11-15 Thread Roman Gushchin
Currently we display some hugepage statistics (total, free, etc) in /proc/meminfo, but only for default hugepage size (e.g. 2Mb). If hugepages of different sizes are used (like 2Mb and 1Gb on x86-64), /proc/meminfo output can be confusing, as non-default sized hugepages are not reflected at all, a