Re: [PATCH v2] mm: terminate shrink_slab loop if signal is pending

2017-12-11 Thread Suren Baghdasaryan
On Sun, Dec 10, 2017 at 2:13 AM, Michal Hocko wrote: > On Fri 08-12-17 10:06:26, Suren Baghdasaryan wrote: >> On Fri, Dec 8, 2017 at 6:03 AM, Tetsuo Handa >> wrote: >> > Michal Hocko wrote: >> >> On Fri 08-12-17 20:36:16, Tetsuo Handa wrote: >> >> > On 2017/12/08 17:22, Michal Hocko wrote: >> >>

Re: [PATCH v2] mm: terminate shrink_slab loop if signal is pending

2017-12-11 Thread Suren Baghdasaryan
On Sat, Dec 9, 2017 at 12:08 AM, Tetsuo Handa wrote: > Suren Baghdasaryan wrote: >> On Fri, Dec 8, 2017 at 6:03 AM, Tetsuo Handa >> wrote: >> >> > >> This change checks for pending >> >> > >> fatal signals inside shrink_slab loop and if one is detected >> >> > >> terminates this loop early. >> >>

Re: [PATCH v2] mm: terminate shrink_slab loop if signal is pending

2017-12-10 Thread Tetsuo Handa
Michal Hocko wrote: > > > I agree that making waits/loops killable is generally good. But be sure > > > to be > > > prepared for the worst case. For example, start __GFP_KILLABLE from "best > > > effort" > > > basis (i.e. no guarantee that the allocating thread will leave the page > > > allocato

Re: [PATCH v2] mm: terminate shrink_slab loop if signal is pending

2017-12-10 Thread Michal Hocko
On Sat 09-12-17 17:08:42, Tetsuo Handa wrote: > Suren Baghdasaryan wrote: > > On Fri, Dec 8, 2017 at 6:03 AM, Tetsuo Handa > > wrote: > > >> > >> This change checks for pending > > >> > >> fatal signals inside shrink_slab loop and if one is detected > > >> > >> terminates this loop early. > > >> >

Re: [PATCH v2] mm: terminate shrink_slab loop if signal is pending

2017-12-10 Thread Michal Hocko
On Fri 08-12-17 10:06:26, Suren Baghdasaryan wrote: > On Fri, Dec 8, 2017 at 6:03 AM, Tetsuo Handa > wrote: > > Michal Hocko wrote: > >> On Fri 08-12-17 20:36:16, Tetsuo Handa wrote: > >> > On 2017/12/08 17:22, Michal Hocko wrote: > >> > > On Thu 07-12-17 17:23:05, Suren Baghdasaryan wrote: > >> >

Re: [PATCH v2] mm: terminate shrink_slab loop if signal is pending

2017-12-09 Thread Tetsuo Handa
On 2017/12/09 6:02, David Rientjes wrote: > On Thu, 7 Dec 2017, Suren Baghdasaryan wrote: > >> Slab shrinkers can be quite time consuming and when signal >> is pending they can delay handling of the signal. If fatal >> signal is pending there is no point in shrinking that process >> since it will

Re: [PATCH v2] mm: terminate shrink_slab loop if signal is pending

2017-12-09 Thread Tetsuo Handa
Suren Baghdasaryan wrote: > On Fri, Dec 8, 2017 at 6:03 AM, Tetsuo Handa > wrote: > >> > >> This change checks for pending > >> > >> fatal signals inside shrink_slab loop and if one is detected > >> > >> terminates this loop early. > >> > > > >> > > This changelog doesn't really address my previou

Re: [PATCH v2] mm: terminate shrink_slab loop if signal is pending

2017-12-08 Thread Suren Baghdasaryan
On Fri, Dec 8, 2017 at 1:02 PM, David Rientjes wrote: > On Thu, 7 Dec 2017, Suren Baghdasaryan wrote: > >> Slab shrinkers can be quite time consuming and when signal >> is pending they can delay handling of the signal. If fatal >> signal is pending there is no point in shrinking that process >> si

Re: [PATCH v2] mm: terminate shrink_slab loop if signal is pending

2017-12-08 Thread David Rientjes
On Thu, 7 Dec 2017, Suren Baghdasaryan wrote: > Slab shrinkers can be quite time consuming and when signal > is pending they can delay handling of the signal. If fatal > signal is pending there is no point in shrinking that process > since it will be killed anyway. This change checks for pending >

Re: [PATCH v2] mm: terminate shrink_slab loop if signal is pending

2017-12-08 Thread Suren Baghdasaryan
On Fri, Dec 8, 2017 at 6:03 AM, Tetsuo Handa wrote: > Michal Hocko wrote: >> On Fri 08-12-17 20:36:16, Tetsuo Handa wrote: >> > On 2017/12/08 17:22, Michal Hocko wrote: >> > > On Thu 07-12-17 17:23:05, Suren Baghdasaryan wrote: >> > >> Slab shrinkers can be quite time consuming and when signal >>

Re: [PATCH v2] mm: terminate shrink_slab loop if signal is pending

2017-12-08 Thread Tetsuo Handa
Michal Hocko wrote: > On Fri 08-12-17 20:36:16, Tetsuo Handa wrote: > > On 2017/12/08 17:22, Michal Hocko wrote: > > > On Thu 07-12-17 17:23:05, Suren Baghdasaryan wrote: > > >> Slab shrinkers can be quite time consuming and when signal > > >> is pending they can delay handling of the signal. If fa

Re: [PATCH v2] mm: terminate shrink_slab loop if signal is pending

2017-12-08 Thread Michal Hocko
On Fri 08-12-17 20:36:16, Tetsuo Handa wrote: > On 2017/12/08 17:22, Michal Hocko wrote: > > On Thu 07-12-17 17:23:05, Suren Baghdasaryan wrote: > >> Slab shrinkers can be quite time consuming and when signal > >> is pending they can delay handling of the signal. If fatal > >> signal is pending the

Re: [PATCH v2] mm: terminate shrink_slab loop if signal is pending

2017-12-08 Thread Tetsuo Handa
On 2017/12/08 17:22, Michal Hocko wrote: > On Thu 07-12-17 17:23:05, Suren Baghdasaryan wrote: >> Slab shrinkers can be quite time consuming and when signal >> is pending they can delay handling of the signal. If fatal >> signal is pending there is no point in shrinking that process >> since it wil

Re: [PATCH v2] mm: terminate shrink_slab loop if signal is pending

2017-12-08 Thread Michal Hocko
On Thu 07-12-17 17:23:05, Suren Baghdasaryan wrote: > Slab shrinkers can be quite time consuming and when signal > is pending they can delay handling of the signal. If fatal > signal is pending there is no point in shrinking that process > since it will be killed anyway. The thing is that we are _

[PATCH v2] mm: terminate shrink_slab loop if signal is pending

2017-12-07 Thread Suren Baghdasaryan
Slab shrinkers can be quite time consuming and when signal is pending they can delay handling of the signal. If fatal signal is pending there is no point in shrinking that process since it will be killed anyway. This change checks for pending fatal signals inside shrink_slab loop and if one is dete