Re: [PATCH v2] mmc: sdhci-cadence: fix logically and structurally dead code

2018-04-20 Thread Ulf Hansson
On 19 April 2018 at 17:59, Gustavo A. R. Silva wrote: > Currently, the code block inside the for loop will never execute > more than once, because the function returns inmediately after > the first iteration, hence the execution of the code at the second > iteration is structurally dead and, code

Re: [PATCH v2] mmc: sdhci-cadence: fix logically and structurally dead code

2018-04-19 Thread Adrian Hunter
On 19/04/18 18:59, Gustavo A. R. Silva wrote: > Currently, the code block inside the for loop will never execute > more than once, because the function returns inmediately after > the first iteration, hence the execution of the code at the second > iteration is structurally dead and, code at line 2

Re: [PATCH v2] mmc: sdhci-cadence: fix logically and structurally dead code

2018-04-19 Thread Masahiro Yamada
2018-04-20 0:59 GMT+09:00 Gustavo A. R. Silva : > Currently, the code block inside the for loop will never execute > more than once, because the function returns inmediately after > the first iteration, hence the execution of the code at the second > iteration is structurally dead and, code at line

[PATCH v2] mmc: sdhci-cadence: fix logically and structurally dead code

2018-04-19 Thread Gustavo A. R. Silva
Currently, the code block inside the for loop will never execute more than once, because the function returns inmediately after the first iteration, hence the execution of the code at the second iteration is structurally dead and, code at line 281: return 0; is never reached. Fix this by checking