Re: [PATCH v2] mtd: spinand: add support for Foresee FS35ND01G-S1Y2

2021-04-08 Thread Miquel Raynal
Hi Daniel, Daniel Palmer wrote on Wed, 7 Apr 2021 21:01:01 +0900: > Hi Miquel, > > On Wed, 7 Apr 2021 at 17:02, Miquel Raynal wrote: > > You may look at micron_8_ecc_get_status() helper to guide you. But > > IMHO, if there are 0-3 bf, you should probably assume there were 3 bf > > and return

Re: [PATCH v2] mtd: spinand: add support for Foresee FS35ND01G-S1Y2

2021-04-07 Thread Daniel Palmer
Hi Miquel, On Wed, 7 Apr 2021 at 17:02, Miquel Raynal wrote: > You may look at micron_8_ecc_get_status() helper to guide you. But > IMHO, if there are 0-3 bf, you should probably assume there were 3 bf > and return 3, if there were 4, return 4, if it's uncorrectable return > -EBADMSG otherwise

Re: [PATCH v2] mtd: spinand: add support for Foresee FS35ND01G-S1Y2

2021-04-07 Thread Miquel Raynal
Hi Daniel, Daniel Palmer wrote on Fri, 26 Mar 2021 23:09:28 +0900: > Hi Miquel, > > Sorry for the constant pestering on this.. > > On Tue, 23 Mar 2021 at 23:06, Miquel Raynal wrote: > > > # nandbiterrs -i /dev/mtd1 > > > incremental biterrors test > > > Successfully corrected 0 bit errors

Re: [PATCH v2] mtd: spinand: add support for Foresee FS35ND01G-S1Y2

2021-03-26 Thread Daniel Palmer
Hi Miquel, Sorry for the constant pestering on this.. On Tue, 23 Mar 2021 at 23:06, Miquel Raynal wrote: > > # nandbiterrs -i /dev/mtd1 > > incremental biterrors test > > Successfully corrected 0 bit errors per subpage > > Inserted biterror @ 0/5 > > Read reported 4 corrected bit errors > > ECC

Re: [PATCH v2] mtd: spinand: add support for Foresee FS35ND01G-S1Y2

2021-03-23 Thread Daniel Palmer
Hi Miquel, On Tue, 23 Mar 2021 at 23:06, Miquel Raynal wrote: > > > > # nandbiterrs -i /dev/mtd1 > > incremental biterrors test > > Successfully corrected 0 bit errors per subpage > > Inserted biterror @ 0/5 > > Read reported 4 corrected bit errors > > ECC failure, invalid data despite read

Re: [PATCH v2] mtd: spinand: add support for Foresee FS35ND01G-S1Y2

2021-03-23 Thread Miquel Raynal
Hi Daniel, Daniel Palmer wrote on Tue, 23 Mar 2021 20:47:10 +0900: > Hi Miquel, > > On Tue, 23 Mar 2021 at 19:32, Miquel Raynal wrote: > > You can run nandbiterrs -i /dev/mtdX > > > > You'll see if there is ECC correction or not (and its level). > > These are results I get for both of the

Re: [PATCH v2] mtd: spinand: add support for Foresee FS35ND01G-S1Y2

2021-03-23 Thread Daniel Palmer
Hi Miquel, On Tue, 23 Mar 2021 at 19:32, Miquel Raynal wrote: > You can run nandbiterrs -i /dev/mtdX > > You'll see if there is ECC correction or not (and its level). These are results I get for both of the nandbiterrs tests. # nandbiterrs -i /dev/mtd1 incremental biterrors test Successfully

Re: [PATCH v2] mtd: spinand: add support for Foresee FS35ND01G-S1Y2

2021-03-23 Thread Miquel Raynal
Hi Daniel, Daniel Palmer wrote on Tue, 23 Mar 2021 18:33:54 +0900: > Hi Miquel, > > On Tue, 23 Mar 2021 at 03:32, Miquel Raynal wrote: > > > I think this shows that the datasheet is right in that the complete 64 > > > bytes of "spare area" is usable. > > > I have no idea where it puts the ECC

Re: [PATCH v2] mtd: spinand: add support for Foresee FS35ND01G-S1Y2

2021-03-23 Thread Daniel Palmer
Hi Miquel, On Tue, 23 Mar 2021 at 03:32, Miquel Raynal wrote: > > I think this shows that the datasheet is right in that the complete 64 > > bytes of "spare area" is usable. > > I have no idea where it puts the ECC though. :) > > Argh, I don't like when hardware tries to be smart. I'm sort of

Re: [PATCH v2] mtd: spinand: add support for Foresee FS35ND01G-S1Y2

2021-03-22 Thread Miquel Raynal
Hi Daniel, Daniel Palmer wrote on Mon, 22 Mar 2021 21:44:40 +0900: > Hi Miquel, > > Sorry for the resend. Gmail randomly switched to HTML email so the > original version seems to have bounced. > > On Mon, 15 Feb 2021 at 20:16, Miquel Raynal wrote: > > > "2. Spare area 800H to 83FH is all

Re: [PATCH v2] mtd: spinand: add support for Foresee FS35ND01G-S1Y2

2021-03-22 Thread Daniel Palmer
Hi Miquel, Sorry for the resend. Gmail randomly switched to HTML email so the original version seems to have bounced. On Mon, 15 Feb 2021 at 20:16, Miquel Raynal wrote: > > "2. Spare area 800H to 83FH is all available for user. > > ECC parity codes are programmed in > > additional space and

Re: [PATCH v2] mtd: spinand: add support for Foresee FS35ND01G-S1Y2

2021-02-15 Thread Daniel Palmer
Hi Miquel, On Mon, 15 Feb 2021 at 20:16, Miquel Raynal wrote: > But a changelog should always be added when you change something > between two versions. And the changelog can be located below the three > dashes ("---") without being part of the final commit message, it does > not need to be in a

Re: [PATCH v2] mtd: spinand: add support for Foresee FS35ND01G-S1Y2

2021-02-15 Thread Miquel Raynal
Hi Daniel, Daniel Palmer wrote on Mon, 15 Feb 2021 19:53:13 +0900: > Hi Miquel, > > On Mon, 15 Feb 2021 at 19:24, Miquel Raynal wrote: > > > > Can you please add a changelog here when you send a new version of a > > patch? > > Sorry, I was going to add a cover letter but elsewhere got told

Re: [PATCH v2] mtd: spinand: add support for Foresee FS35ND01G-S1Y2

2021-02-15 Thread Daniel Palmer
Hi Miquel, On Mon, 15 Feb 2021 at 19:24, Miquel Raynal wrote: > > Can you please add a changelog here when you send a new version of a > patch? Sorry, I was going to add a cover letter but elsewhere got told that one isn't needed for a single patch.. Basically I changed FS35ND01G to

Re: [PATCH v2] mtd: spinand: add support for Foresee FS35ND01G-S1Y2

2021-02-15 Thread Miquel Raynal
Hi Daniel, Daniel Palmer wrote on Sat, 13 Feb 2021 18:57:24 +0900: > Add support for the Foresee FS35ND01G-S1Y2 manufactured by Longsys. > > Signed-off-by: Daniel Palmer > > Link: > https://datasheet.lcsc.com/szlcsc/2008121142_FORESEE-FS35ND01G-S1Y2QWFI000_C719495.pdf > --- Can you please

[PATCH v2] mtd: spinand: add support for Foresee FS35ND01G-S1Y2

2021-02-13 Thread Daniel Palmer
Add support for the Foresee FS35ND01G-S1Y2 manufactured by Longsys. Signed-off-by: Daniel Palmer Link: https://datasheet.lcsc.com/szlcsc/2008121142_FORESEE-FS35ND01G-S1Y2QWFI000_C719495.pdf --- drivers/mtd/nand/spi/Makefile | 2 +- drivers/mtd/nand/spi/core.c| 1 +