Re: [PATCH v2] mtd: ubi: Extend UBI layer debug/messaging capabilities

2014-10-06 Thread Ricard Wanderlof
On Fri, 3 Oct 2014, Artem Bityutskiy wrote: > I respect checkpatch.pl, and uniformity / consistency, but in this > particular case I put my maintainer hat on and say that for this kernel > subsystem it is fine, because the maintainer will be more efficient in > maintaining this code when the

Re: [PATCH v2] mtd: ubi: Extend UBI layer debug/messaging capabilities

2014-10-06 Thread Ricard Wanderlof
On Fri, 3 Oct 2014, Artem Bityutskiy wrote: I respect checkpatch.pl, and uniformity / consistency, but in this particular case I put my maintainer hat on and say that for this kernel subsystem it is fine, because the maintainer will be more efficient in maintaining this code when the code is

Re: [PATCH v2] mtd: ubi: Extend UBI layer debug/messaging capabilities

2014-10-03 Thread Rafał Miłecki
On 3 October 2014 18:19, Artem Bityutskiy wrote: > On Fri, 2014-10-03 at 17:50 +0200, Rafał Miłecki wrote: >> On 3 October 2014 17:27, Artem Bityutskiy wrote: >> > Yes, I guess a single patch is indeed OK. I have few nit-picks, though. >> > >> > On Tue, 2014-09-30 at 18:13 +0300, Tanya Brokhman

Re: [PATCH v2] mtd: ubi: Extend UBI layer debug/messaging capabilities

2014-10-03 Thread Artem Bityutskiy
On Fri, 2014-10-03 at 17:50 +0200, Rafał Miłecki wrote: > On 3 October 2014 17:27, Artem Bityutskiy wrote: > > Yes, I guess a single patch is indeed OK. I have few nit-picks, though. > > > > On Tue, 2014-09-30 at 18:13 +0300, Tanya Brokhman wrote: > >> -

Re: [PATCH v2] mtd: ubi: Extend UBI layer debug/messaging capabilities

2014-10-03 Thread Rafał Miłecki
On 3 October 2014 17:27, Artem Bityutskiy wrote: > Yes, I guess a single patch is indeed OK. I have few nit-picks, though. > > On Tue, 2014-09-30 at 18:13 +0300, Tanya Brokhman wrote: >> - ubi_err("'ubi_io_read_ec_hdr()' returned unknown code %d", >> err); >> +

Re: [PATCH v2] mtd: ubi: Extend UBI layer debug/messaging capabilities

2014-10-03 Thread Artem Bityutskiy
Yes, I guess a single patch is indeed OK. I have few nit-picks, though. On Tue, 2014-09-30 at 18:13 +0300, Tanya Brokhman wrote: > - ubi_err("'ubi_io_read_ec_hdr()' returned unknown code %d", err); > + ubi_err(ubi, > + "'ubi_io_read_ec_hdr()' returned unknown

Re: [PATCH v2] mtd: ubi: Extend UBI layer debug/messaging capabilities

2014-10-03 Thread Artem Bityutskiy
Yes, I guess a single patch is indeed OK. I have few nit-picks, though. On Tue, 2014-09-30 at 18:13 +0300, Tanya Brokhman wrote: - ubi_err('ubi_io_read_ec_hdr()' returned unknown code %d, err); + ubi_err(ubi, + 'ubi_io_read_ec_hdr()' returned unknown code

Re: [PATCH v2] mtd: ubi: Extend UBI layer debug/messaging capabilities

2014-10-03 Thread Rafał Miłecki
On 3 October 2014 17:27, Artem Bityutskiy dedeki...@gmail.com wrote: Yes, I guess a single patch is indeed OK. I have few nit-picks, though. On Tue, 2014-09-30 at 18:13 +0300, Tanya Brokhman wrote: - ubi_err('ubi_io_read_ec_hdr()' returned unknown code %d, err); +

Re: [PATCH v2] mtd: ubi: Extend UBI layer debug/messaging capabilities

2014-10-03 Thread Artem Bityutskiy
On Fri, 2014-10-03 at 17:50 +0200, Rafał Miłecki wrote: On 3 October 2014 17:27, Artem Bityutskiy dedeki...@gmail.com wrote: Yes, I guess a single patch is indeed OK. I have few nit-picks, though. On Tue, 2014-09-30 at 18:13 +0300, Tanya Brokhman wrote: -

Re: [PATCH v2] mtd: ubi: Extend UBI layer debug/messaging capabilities

2014-10-03 Thread Rafał Miłecki
On 3 October 2014 18:19, Artem Bityutskiy dedeki...@gmail.com wrote: On Fri, 2014-10-03 at 17:50 +0200, Rafał Miłecki wrote: On 3 October 2014 17:27, Artem Bityutskiy dedeki...@gmail.com wrote: Yes, I guess a single patch is indeed OK. I have few nit-picks, though. On Tue, 2014-09-30 at

[PATCH v2] mtd: ubi: Extend UBI layer debug/messaging capabilities

2014-09-30 Thread Tanya Brokhman
If there is more then one UBI device mounted, there is no way to distinguish between messages from different UBI devices. Add device number to all ubi layer message types. Signed-off-by: Tanya Brokhman --- Changes from V1: - Compilation error fixed - macros were updated to

[PATCH v2] mtd: ubi: Extend UBI layer debug/messaging capabilities

2014-09-30 Thread Tanya Brokhman
If there is more then one UBI device mounted, there is no way to distinguish between messages from different UBI devices. Add device number to all ubi layer message types. Signed-off-by: Tanya Brokhman tlin...@codeaurora.org --- Changes from V1: - Compilation error fixed - macros