Re: [PATCH v2] mwifiex: fix possible NULL dereference

2016-04-12 Thread Sudip Mukherjee
On Tuesday 12 April 2016 05:20 PM, Arend van Spriel wrote: On 12-04-16 13:46, Sudip Mukherjee wrote: From: Sudip Mukherjee We have a check for card just after dereferencing it. So if it is NULL we have already dereferenced it before its check. Lets

Re: [PATCH v2] mwifiex: fix possible NULL dereference

2016-04-12 Thread Sudip Mukherjee
On Tuesday 12 April 2016 05:20 PM, Arend van Spriel wrote: On 12-04-16 13:46, Sudip Mukherjee wrote: From: Sudip Mukherjee We have a check for card just after dereferencing it. So if it is NULL we have already dereferenced it before its check. Lets dereference it after checking card for

Re: [PATCH v2] mwifiex: fix possible NULL dereference

2016-04-12 Thread Arend van Spriel
On 12-04-16 13:46, Sudip Mukherjee wrote: > From: Sudip Mukherjee > > We have a check for card just after dereferencing it. So if it is NULL > we have already dereferenced it before its check. Lets dereference it > after checking card for NULL. And you are

Re: [PATCH v2] mwifiex: fix possible NULL dereference

2016-04-12 Thread Arend van Spriel
On 12-04-16 13:46, Sudip Mukherjee wrote: > From: Sudip Mukherjee > > We have a check for card just after dereferencing it. So if it is NULL > we have already dereferenced it before its check. Lets dereference it > after checking card for NULL. And you are changing the scope of the pdev

[PATCH v2] mwifiex: fix possible NULL dereference

2016-04-12 Thread Sudip Mukherjee
From: Sudip Mukherjee We have a check for card just after dereferencing it. So if it is NULL we have already dereferenced it before its check. Lets dereference it after checking card for NULL. Signed-off-by: Sudip Mukherjee ---

[PATCH v2] mwifiex: fix possible NULL dereference

2016-04-12 Thread Sudip Mukherjee
From: Sudip Mukherjee We have a check for card just after dereferencing it. So if it is NULL we have already dereferenced it before its check. Lets dereference it after checking card for NULL. Signed-off-by: Sudip Mukherjee --- drivers/net/wireless/marvell/mwifiex/pcie.c | 3 ++- 1 file