RE: [PATCH v2] net/socket: fix GCC8+ Wpacked-not-aligned warnings

2019-07-30 Thread David Laight
From: Qian Cai > Sent: 30 July 2019 15:38 ... > Use an implicit alignment for "struct __kernel_sockaddr_storage" so it > can keep the same alignments as a member in both packed and un-packed > structures without breaking UAPI. > > Suggested-by: David Laight ... Although I suggested it needs a bi

Re: [PATCH v2] net/socket: fix GCC8+ Wpacked-not-aligned warnings

2019-07-30 Thread Marcelo Ricardo Leitner
On Tue, Jul 30, 2019 at 10:38:08AM -0400, Qian Cai wrote: > In file included from ./include/linux/sctp.h:42, > from net/core/skbuff.c:47: > ./include/uapi/linux/sctp.h:395:1: warning: alignment 4 of 'struct > sctp_paddr_change' is less than 8 [-Wpacked-not-aligned] > } __attribute

[PATCH v2] net/socket: fix GCC8+ Wpacked-not-aligned warnings

2019-07-30 Thread Qian Cai
In file included from ./include/linux/sctp.h:42, from net/core/skbuff.c:47: ./include/uapi/linux/sctp.h:395:1: warning: alignment 4 of 'struct sctp_paddr_change' is less than 8 [-Wpacked-not-aligned] } __attribute__((packed, aligned(4))); ^ ./include/uapi/linux/sctp.h:728:1: warn