Re: [PATCH v2] net/wireless/brcm80211/brcmfmac: Make return type and name reflect actual semantics

2014-06-22 Thread Arend van Spriel
On 06/22/14 11:27, Arend van Spriel wrote: On 06/22/14 00:55, Rasmus Villemoes wrote: Applying ++ to a bool is equivalent to setting it true, regardless of its initial value (bools are not uint1_t). Hence the function wl_get_vif_state_all can only ever return true/false. The only in-tree caller

Re: [PATCH v2] net/wireless/brcm80211/brcmfmac: Make return type and name reflect actual semantics

2014-06-22 Thread Arend van Spriel
On 06/22/14 00:55, Rasmus Villemoes wrote: Applying ++ to a bool is equivalent to setting it true, regardless of its initial value (bools are not uint1_t). Hence the function wl_get_vif_state_all can only ever return true/false. The only in-tree caller uses its return value as a boolean. So

Re: [PATCH v2] net/wireless/brcm80211/brcmfmac: Make return type and name reflect actual semantics

2014-06-22 Thread Arend van Spriel
On 06/22/14 00:55, Rasmus Villemoes wrote: Applying ++ to a bool is equivalent to setting it true, regardless of its initial value (bools are not uint1_t). Hence the function wl_get_vif_state_all can only ever return true/false. The only in-tree caller uses its return value as a boolean. So

Re: [PATCH v2] net/wireless/brcm80211/brcmfmac: Make return type and name reflect actual semantics

2014-06-22 Thread Arend van Spriel
On 06/22/14 11:27, Arend van Spriel wrote: On 06/22/14 00:55, Rasmus Villemoes wrote: Applying ++ to a bool is equivalent to setting it true, regardless of its initial value (bools are not uint1_t). Hence the function wl_get_vif_state_all can only ever return true/false. The only in-tree caller

[PATCH v2] net/wireless/brcm80211/brcmfmac: Make return type and name reflect actual semantics

2014-06-21 Thread Rasmus Villemoes
Applying ++ to a bool is equivalent to setting it true, regardless of its initial value (bools are not uint1_t). Hence the function wl_get_vif_state_all can only ever return true/false. The only in-tree caller uses its return value as a boolean. So update its return type, and since the list

[PATCH v2] net/wireless/brcm80211/brcmfmac: Make return type and name reflect actual semantics

2014-06-21 Thread Rasmus Villemoes
Applying ++ to a bool is equivalent to setting it true, regardless of its initial value (bools are not uint1_t). Hence the function wl_get_vif_state_all can only ever return true/false. The only in-tree caller uses its return value as a boolean. So update its return type, and since the list