Re: [PATCH v2] net: fec: Add "phy-reset-active-low" property to DT

2016-02-21 Thread Sergei Shtylyov
Hello. On 02/09/2016 11:01 PM, Bernhard Walle wrote: We need that for a custom hardware that needs the reverse reset sequence. Signed-off-by: Bernhard Walle --- Changes compared to v1: - Add documentation to 'phy-reset-gpios' that flags are ignored as suggested by Andrew Lunn. Docume

Re: [PATCH v2] net: fec: Add "phy-reset-active-low" property to DT

2016-02-12 Thread Rob Herring
On Fri, Feb 12, 2016 at 9:24 AM, Fabio Estevam wrote: > On Fri, Feb 12, 2016 at 1:20 PM, Rob Herring wrote: > >> This is what the gpio flags are for. Why can't you use that? > > This has already been discussed in v1: > https://lkml.org/lkml/2016/2/8/867 Thanks. That's fine, but that detail shoul

Re: [PATCH v2] net: fec: Add "phy-reset-active-low" property to DT

2016-02-12 Thread Rob Herring
On Tue, Feb 09, 2016 at 09:01:12PM +0100, Bernhard Walle wrote: > We need that for a custom hardware that needs the reverse reset > sequence. > > Signed-off-by: Bernhard Walle > --- > Changes compared to v1: > - Add documentation to 'phy-reset-gpios' that flags are ignored >as suggested by A

Re: [PATCH v2] net: fec: Add "phy-reset-active-low" property to DT

2016-02-12 Thread Fabio Estevam
On Fri, Feb 12, 2016 at 1:20 PM, Rob Herring wrote: > This is what the gpio flags are for. Why can't you use that? This has already been discussed in v1: https://lkml.org/lkml/2016/2/8/867

Re: [PATCH v2] net: fec: Add "phy-reset-active-low" property to DT

2016-02-10 Thread Andrew Lunn
On Tue, Feb 09, 2016 at 09:01:12PM +0100, Bernhard Walle wrote: > We need that for a custom hardware that needs the reverse reset > sequence. > > Signed-off-by: Bernhard Walle Thanks for updating the Documentation. Reviewed-by: Andrew Lunn Andrew > --- > Changes compared to v1: > - Add

Re: [PATCH v2] net: fec: Add "phy-reset-active-low" property to DT

2016-02-09 Thread Fabio Estevam
Hi Bernhard, On Tue, Feb 9, 2016 at 6:01 PM, Bernhard Walle wrote: > We need that for a custom hardware that needs the reverse reset > sequence. > > Signed-off-by: Bernhard Walle Looks good: Reviewed-by: Fabio Estevam

[PATCH v2] net: fec: Add "phy-reset-active-low" property to DT

2016-02-09 Thread Bernhard Walle
We need that for a custom hardware that needs the reverse reset sequence. Signed-off-by: Bernhard Walle --- Changes compared to v1: - Add documentation to 'phy-reset-gpios' that flags are ignored as suggested by Andrew Lunn. Documentation/devicetree/bindings/net/fsl-fec.txt | 7 ++- dri