Re: [PATCH v2] net: introduce helper macro for_each_cmsghdr

2014-12-10 Thread Gu Zheng
Hi David, On 12/11/2014 09:47 AM, David Miller wrote: > From: Gu Zheng > Date: Thu, 11 Dec 2014 09:05:59 +0800 > >> IMO, the user-land programs need to be build with the matched >> headers separately. > > You absolutely cannot provide this new interface to userland and > expect programs to be a

Re: [PATCH v2] net: introduce helper macro for_each_cmsghdr

2014-12-10 Thread David Miller
From: Gu Zheng Date: Thu, 11 Dec 2014 09:05:59 +0800 > IMO, the user-land programs need to be build with the matched > headers separately. You absolutely cannot provide this new interface to userland and expect programs to be able to just use it, it's non-standard and does not exist in older hea

Re: [PATCH v2] net: introduce helper macro for_each_cmsghdr

2014-12-10 Thread Gu Zheng
Hi Joe, On 12/10/2014 10:51 PM, Joe Perches wrote: > On Wed, 2014-12-10 at 16:15 +0800, Gu Zheng wrote: >> On 12/10/2014 02:56 PM, Joe Perches wrote: >>> On Wed, 2014-12-10 at 13:36 +0800, Gu Zheng wrote: Introduce helper macro for_each_cmsghdr as a wrapper of the enumerating cmsghdr fro

Re: [PATCH v2] net: introduce helper macro for_each_cmsghdr

2014-12-10 Thread Gu Zheng
Hi David, On 12/11/2014 03:44 AM, David Miller wrote: > From: David Miller > Date: Wed, 10 Dec 2014 13:48:04 -0500 (EST) > >> From: Gu Zheng >> Date: Wed, 10 Dec 2014 13:36:25 +0800 >> >>> Introduce helper macro for_each_cmsghdr as a wrapper of the enumerating >>> cmsghdr from msghdr, just clea

Re: [PATCH v2] net: introduce helper macro for_each_cmsghdr

2014-12-10 Thread David Miller
From: David Miller Date: Wed, 10 Dec 2014 13:48:04 -0500 (EST) > From: Gu Zheng > Date: Wed, 10 Dec 2014 13:36:25 +0800 > >> Introduce helper macro for_each_cmsghdr as a wrapper of the enumerating >> cmsghdr from msghdr, just cleanup. >> >> Signed-off-by: Gu Zheng > > Applied, thanks. This

Re: [PATCH v2] net: introduce helper macro for_each_cmsghdr

2014-12-10 Thread David Miller
From: Gu Zheng Date: Wed, 10 Dec 2014 13:36:25 +0800 > Introduce helper macro for_each_cmsghdr as a wrapper of the enumerating > cmsghdr from msghdr, just cleanup. > > Signed-off-by: Gu Zheng Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the bo

Re: [PATCH v2] net: introduce helper macro for_each_cmsghdr

2014-12-10 Thread Joe Perches
On Wed, 2014-12-10 at 16:15 +0800, Gu Zheng wrote: > On 12/10/2014 02:56 PM, Joe Perches wrote: > > On Wed, 2014-12-10 at 13:36 +0800, Gu Zheng wrote: > >> Introduce helper macro for_each_cmsghdr as a wrapper of the enumerating > >> cmsghdr from msghdr, just cleanup. > > > > This looks nicer. > >

Re: [PATCH v2] net: introduce helper macro for_each_cmsghdr

2014-12-10 Thread Gu Zheng
Hi Joe, On 12/10/2014 02:56 PM, Joe Perches wrote: > On Wed, 2014-12-10 at 13:36 +0800, Gu Zheng wrote: >> Introduce helper macro for_each_cmsghdr as a wrapper of the enumerating >> cmsghdr from msghdr, just cleanup. > > This looks nicer. > Ideally this would have used: [PATCH V3] as the subject

Re: [PATCH v2] net: introduce helper macro for_each_cmsghdr

2014-12-09 Thread Joe Perches
On Wed, 2014-12-10 at 13:36 +0800, Gu Zheng wrote: > Introduce helper macro for_each_cmsghdr as a wrapper of the enumerating > cmsghdr from msghdr, just cleanup. This looks nicer. Ideally this would have used: [PATCH V3] as the subject > Signed-off-by: Gu Zheng > --- > v2: use the lower-case ma

[PATCH v2] net: introduce helper macro for_each_cmsghdr

2014-12-09 Thread Gu Zheng
Introduce helper macro for_each_cmsghdr as a wrapper of the enumerating cmsghdr from msghdr, just cleanup. Signed-off-by: Gu Zheng --- v2: use the lower-case macro name as Joe suggested. --- .../networking/timestamping/timestamping.c |4 +--- .../networking/timestamping/txtimestamp.

Re: [PATCH v2] net: introduce helper macro for_each_cmsghdr

2014-12-09 Thread Gu Zheng
Hi Joe, On 12/10/2014 10:01 AM, Joe Perches wrote: > On Wed, 2014-12-10 at 09:39 +0800, Gu Zheng wrote: >> Introduce helper macro for_each_cmsghdr as a wrapper of the enumerating >> cmsghdr from msghdr, just cleanup. > > Does this even compile? > > So which is it? > > for_each_cmsghdr >

Re: [PATCH v2] net: introduce helper macro for_each_cmsghdr

2014-12-09 Thread Gu Zheng
There's a mistake in this patch, please ignore it. Sorry for the noise. Regards, Gu On 12/10/2014 09:39 AM, Gu Zheng wrote: > Introduce helper macro for_each_cmsghdr as a wrapper of the enumerating > cmsghdr from msghdr, just cleanup. > > > Signed-off-by: Gu Zheng > --- > v2: use the lower-ca

Re: [PATCH v2] net: introduce helper macro for_each_cmsghdr

2014-12-09 Thread Joe Perches
On Wed, 2014-12-10 at 09:39 +0800, Gu Zheng wrote: > Introduce helper macro for_each_cmsghdr as a wrapper of the enumerating > cmsghdr from msghdr, just cleanup. Does this even compile? So which is it? for_each_cmsghdr or for_each_cmsg_hdr? The .h #defines for_each_cmsg_hdr but

[PATCH v2] net: introduce helper macro for_each_cmsghdr

2014-12-09 Thread Gu Zheng
Introduce helper macro for_each_cmsghdr as a wrapper of the enumerating cmsghdr from msghdr, just cleanup. Signed-off-by: Gu Zheng --- v2: use the lower-case macro name as Joe suggested. --- .../networking/timestamping/timestamping.c |4 +--- .../networking/timestamping/txtimestamp