Re: [PATCH v2] net: ipv6: fix use-after-free Read in __xfrm6_tunnel_spi_lookup

2020-07-28 Thread David Miller
From: B K Karthik Date: Sun, 26 Jul 2020 08:38:55 +0530 > @@ -103,10 +103,10 @@ static int __xfrm6_tunnel_spi_check(struct net *net, > u32 spi) > { > struct xfrm6_tunnel_net *xfrm6_tn = xfrm6_tunnel_pernet(net); > struct xfrm6_tunnel_spi *x6spi; > - int index =

Re: [PATCH v2] net: ipv6: fix use-after-free Read in __xfrm6_tunnel_spi_lookup

2020-07-27 Thread Steffen Klassert
On Sat, Jul 25, 2020 at 10:35:12PM -0700, Cong Wang wrote: > On Sat, Jul 25, 2020 at 8:09 PM B K Karthik wrote: > > @@ -103,10 +103,10 @@ static int __xfrm6_tunnel_spi_check(struct net *net, > > u32 spi) > > { > > struct xfrm6_tunnel_net *xfrm6_tn = xfrm6_tunnel_pernet(net); > >

Re: [PATCH v2] net: ipv6: fix use-after-free Read in __xfrm6_tunnel_spi_lookup

2020-07-26 Thread B K Karthik
On Mon, Jul 27, 2020 at 1:37 AM Cong Wang wrote: > > On Sat, Jul 25, 2020 at 11:12 PM B K Karthik wrote: > > > > On Sun, Jul 26, 2020 at 11:05 AM Cong Wang wrote: > > > > > > On Sat, Jul 25, 2020 at 8:09 PM B K Karthik > > > wrote: > > > > @@ -103,10 +103,10 @@ static int

Re: [PATCH v2] net: ipv6: fix use-after-free Read in __xfrm6_tunnel_spi_lookup

2020-07-26 Thread Cong Wang
On Sat, Jul 25, 2020 at 11:12 PM B K Karthik wrote: > > On Sun, Jul 26, 2020 at 11:05 AM Cong Wang wrote: > > > > On Sat, Jul 25, 2020 at 8:09 PM B K Karthik wrote: > > > @@ -103,10 +103,10 @@ static int __xfrm6_tunnel_spi_check(struct net > > > *net, u32 spi) > > > { > > > struct

Re: [PATCH v2] net: ipv6: fix use-after-free Read in __xfrm6_tunnel_spi_lookup

2020-07-26 Thread kernel test robot
Hi K, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on ipsec/master] [also build test WARNING on ipsec-next/master sparc-next/master net-next/master net/master v5.8-rc6 next-20200724] [If your patch is applied to the wrong git tree, kindly drop us a note. And

Re: [PATCH v2] net: ipv6: fix use-after-free Read in __xfrm6_tunnel_spi_lookup

2020-07-26 Thread kernel test robot
Hi K, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on ipsec/master] [also build test WARNING on ipsec-next/master sparc-next/master net-next/master net/master v5.8-rc6 next-20200724] [If your patch is applied to the wrong git tree, kindly drop us a note. And

Re: [PATCH v2] net: ipv6: fix use-after-free Read in __xfrm6_tunnel_spi_lookup

2020-07-26 Thread B K Karthik
On Sun, Jul 26, 2020 at 11:05 AM Cong Wang wrote: > > On Sat, Jul 25, 2020 at 8:09 PM B K Karthik wrote: > > @@ -103,10 +103,10 @@ static int __xfrm6_tunnel_spi_check(struct net *net, > > u32 spi) > > { > > struct xfrm6_tunnel_net *xfrm6_tn = xfrm6_tunnel_pernet(net); > >

Re: [PATCH v2] net: ipv6: fix use-after-free Read in __xfrm6_tunnel_spi_lookup

2020-07-25 Thread Cong Wang
On Sat, Jul 25, 2020 at 8:09 PM B K Karthik wrote: > @@ -103,10 +103,10 @@ static int __xfrm6_tunnel_spi_check(struct net *net, > u32 spi) > { > struct xfrm6_tunnel_net *xfrm6_tn = xfrm6_tunnel_pernet(net); > struct xfrm6_tunnel_spi *x6spi; > - int index =

[PATCH v2] net: ipv6: fix use-after-free Read in __xfrm6_tunnel_spi_lookup

2020-07-25 Thread B K Karthik
__xfrm_tunnel_spi_check used xfrm6_tunnel_spi_has_byspi which returns spi % XFRM6_TUNNEL_SPI_BYSPI_HSIZE. whereas xfrm6_tunnel_spi_hash_byaddr makes a call to ipv6_addr_hash. netdevsim netdevsim0 netdevsim1: set [1, 0] type 2 family 0 port 6081 - 0 netdevsim netdevsim0 netdevsim2: set [1, 0] type