Re: [PATCH v2] nvme-pci: Save PCI state before putting drive into deepest state

2019-09-27 Thread Christoph Hellwig
Looks sensible to me: Reviewed-by: Christoph Hellwig

Re: [PATCH v2] nvme-pci: Save PCI state before putting drive into deepest state

2019-09-20 Thread Keith Busch
On Wed, Sep 18, 2019 at 01:15:55PM -0500, Mario Limonciello wrote: > The action of saving the PCI state will cause numerous PCI configuration > space reads which depending upon the vendor implementation may cause > the drive to exit the deepest NVMe state. > > In these cases ASPM will typically

Re: [PATCH v2] nvme-pci: Save PCI state before putting drive into deepest state

2019-09-20 Thread Sagi Grimberg
Keith, can we get a review from you for this?

[PATCH v2] nvme-pci: Save PCI state before putting drive into deepest state

2019-09-18 Thread Mario Limonciello
The action of saving the PCI state will cause numerous PCI configuration space reads which depending upon the vendor implementation may cause the drive to exit the deepest NVMe state. In these cases ASPM will typically resolve the PCIe link state and APST may resolve the NVMe power state.