Re: [PATCH v2] objtool: move libelf detection to Kconfig from Makefile

2018-07-10 Thread Kees Cook
On Mon, Jul 9, 2018 at 9:26 PM, Josh Poimboeuf wrote: > I wasn't a part of the -fstack-protector conversation, but I doubt it's > the same pattern. We're trying to phase out frame pointers, for several > reasons. One big reason is that they cause a general slowdown across > the entire kernel. M

Re: [PATCH v2] objtool: move libelf detection to Kconfig from Makefile

2018-07-09 Thread Ingo Molnar
* Josh Poimboeuf wrote: > Since we switched the x86_64 default to the ORC unwinder, a lot of > people have switched over. But this patch will reverse (or at least > slow down) that trend, because almost nobody has the libelf devel > packaged installed by default. So over time, it will effecti

Re: [PATCH v2] objtool: move libelf detection to Kconfig from Makefile

2018-07-09 Thread Josh Poimboeuf
On Tue, Jul 10, 2018 at 12:47:49PM +0900, Masahiro Yamada wrote: > Hi. > > > 2018-07-10 11:29 GMT+09:00 Josh Poimboeuf : > > On Tue, Jul 10, 2018 at 10:35:16AM +0900, Masahiro Yamada wrote: > >> Currently, users are allowed to enable STACK_VALIDATION regardless > >> of the compiler capability. T

Re: [PATCH v2] objtool: move libelf detection to Kconfig from Makefile

2018-07-09 Thread Masahiro Yamada
Hi. 2018-07-10 11:29 GMT+09:00 Josh Poimboeuf : > On Tue, Jul 10, 2018 at 10:35:16AM +0900, Masahiro Yamada wrote: >> Currently, users are allowed to enable STACK_VALIDATION regardless >> of the compiler capability. The top-level Makefile warns or breaks >> the build if it turns out that the hos

Re: [PATCH v2] objtool: move libelf detection to Kconfig from Makefile

2018-07-09 Thread Josh Poimboeuf
On Tue, Jul 10, 2018 at 10:35:16AM +0900, Masahiro Yamada wrote: > Currently, users are allowed to enable STACK_VALIDATION regardless > of the compiler capability. The top-level Makefile warns or breaks > the build if it turns out that the host compiler cannot link libelf. > > Move the libelf tes

[PATCH v2] objtool: move libelf detection to Kconfig from Makefile

2018-07-09 Thread Masahiro Yamada
Currently, users are allowed to enable STACK_VALIDATION regardless of the compiler capability. The top-level Makefile warns or breaks the build if it turns out that the host compiler cannot link libelf. Move the libelf test to Kconfig so that users can enable the feature only when the host compil