Re: [PATCH v2] perf/core: Fix installing cgroup event into cpu

2018-01-24 Thread Lin Xiulei
2018-01-24 17:46 GMT+08:00 Peter Zijlstra : > On Wed, Jan 24, 2018 at 05:19:34PM +0800, Lin Xiulei wrote: >> Sure, and I consider this "OK" works for "What goes wrong if we leave >> it set?". : ) > > It would be good if you inspect the code for the case of leaving > cpuctx->cgrp set with no cgroup

Re: [PATCH v2] perf/core: Fix installing cgroup event into cpu

2018-01-24 Thread Peter Zijlstra
On Wed, Jan 24, 2018 at 05:19:34PM +0800, Lin Xiulei wrote: > Sure, and I consider this "OK" works for "What goes wrong if we leave > it set?". : ) It would be good if you inspect the code for the case of leaving cpuctx->cgrp set with no cgroup events left -- AND -- put a blurb about what you foun

Re: [PATCH v2] perf/core: Fix installing cgroup event into cpu

2018-01-24 Thread Lin Xiulei
2018-01-24 17:14 GMT+08:00 Peter Zijlstra : > On Wed, Jan 24, 2018 at 04:32:38PM +0800, Lin Xiulei wrote: >> >> kernel/events/core.c | 44 +++- >> >> 1 file changed, 31 insertions(+), 13 deletions(-) >> >> >> >> diff --git a/kernel/events/core.c b/kernel/eve

Re: [PATCH v2] perf/core: Fix installing cgroup event into cpu

2018-01-24 Thread Peter Zijlstra
On Wed, Jan 24, 2018 at 04:32:38PM +0800, Lin Xiulei wrote: > >> kernel/events/core.c | 44 +++- > >> 1 file changed, 31 insertions(+), 13 deletions(-) > >> > >> diff --git a/kernel/events/core.c b/kernel/events/core.c > >> index 4df5b69..f766b60 100644 > >>

Re: [PATCH v2] perf/core: Fix installing cgroup event into cpu

2018-01-24 Thread Lin Xiulei
2018-01-24 16:20 GMT+08:00 Peter Zijlstra : > On Wed, Jan 24, 2018 at 03:50:10PM +0800, linxiu...@gmail.com wrote: >> From: "leilei.lin" >> >> Do not install cgroup event into the CPU context if the cgroup >> is not running on this CPU >> >> While there is no task of cgroup running specified CPU,

Re: [PATCH v2] perf/core: Fix installing cgroup event into cpu

2018-01-24 Thread Peter Zijlstra
On Wed, Jan 24, 2018 at 03:50:10PM +0800, linxiu...@gmail.com wrote: > From: "leilei.lin" > > Do not install cgroup event into the CPU context if the cgroup > is not running on this CPU > > While there is no task of cgroup running specified CPU, current > kernel still install cgroup event into C

[PATCH v2] perf/core: Fix installing cgroup event into cpu

2018-01-23 Thread linxiulei
From: "leilei.lin" Do not install cgroup event into the CPU context if the cgroup is not running on this CPU While there is no task of cgroup running specified CPU, current kernel still install cgroup event into CPU context, that causes another cgroup event can't be installed into this CPU. Sig