Re: [PATCH v2] perf annotate: fix parsing aarch64 branch instructions after objdump update

2018-08-30 Thread Arnaldo Carvalho de Melo
Em Mon, Aug 27, 2018 at 12:53:40PM -0500, Kim Phillips escreveu: > v2: address acme's comments: > - consolidate into a validate_comma() > - call from an additional couple of places necessary > - don't listen to checkpatch wrt reflowing jump__parse definition > line to less than 80

[PATCH v2] perf annotate: fix parsing aarch64 branch instructions after objdump update

2018-08-27 Thread Kim Phillips
Starting with binutils 2.28, aarch64 objdump adds comments to the disassembly output to show the alternative names of a condition code [1]. It is assumed that commas in objdump comments could occur in other arches now or in the future, so this fix is arch-independent. The fix could have been done