Re: [PATCH v2] perf ftrace: Fix the buffer size in __write_tracing_file

2018-02-12 Thread Du, Changbin
On Sun, Feb 11, 2018 at 10:15:10PM -0800, Namhyung Kim wrote: > On Mon, Feb 12, 2018 at 12:48:15PM +0800, Du, Changbin wrote: > > Hi, > > > > On Mon, Feb 12, 2018 at 10:55:27AM +0900, Namhyung Kim wrote: > > > Hello, > > > > > > On Thu, Feb 08, 2018 at 04:13:20PM +0800, changbin...@intel.com

Re: [PATCH v2] perf ftrace: Fix the buffer size in __write_tracing_file

2018-02-12 Thread Du, Changbin
On Sun, Feb 11, 2018 at 10:15:10PM -0800, Namhyung Kim wrote: > On Mon, Feb 12, 2018 at 12:48:15PM +0800, Du, Changbin wrote: > > Hi, > > > > On Mon, Feb 12, 2018 at 10:55:27AM +0900, Namhyung Kim wrote: > > > Hello, > > > > > > On Thu, Feb 08, 2018 at 04:13:20PM +0800, changbin...@intel.com

Re: [PATCH v2] perf ftrace: Fix the buffer size in __write_tracing_file

2018-02-11 Thread Namhyung Kim
On Mon, Feb 12, 2018 at 12:48:15PM +0800, Du, Changbin wrote: > Hi, > > On Mon, Feb 12, 2018 at 10:55:27AM +0900, Namhyung Kim wrote: > > Hello, > > > > On Thu, Feb 08, 2018 at 04:13:20PM +0800, changbin...@intel.com wrote: > > > From: Changbin Du > > > > > > The

Re: [PATCH v2] perf ftrace: Fix the buffer size in __write_tracing_file

2018-02-11 Thread Namhyung Kim
On Mon, Feb 12, 2018 at 12:48:15PM +0800, Du, Changbin wrote: > Hi, > > On Mon, Feb 12, 2018 at 10:55:27AM +0900, Namhyung Kim wrote: > > Hello, > > > > On Thu, Feb 08, 2018 at 04:13:20PM +0800, changbin...@intel.com wrote: > > > From: Changbin Du > > > > > > The terminal character '\0' should

Re: [PATCH v2] perf ftrace: Fix the buffer size in __write_tracing_file

2018-02-11 Thread Du, Changbin
Hi, On Mon, Feb 12, 2018 at 10:55:27AM +0900, Namhyung Kim wrote: > Hello, > > On Thu, Feb 08, 2018 at 04:13:20PM +0800, changbin...@intel.com wrote: > > From: Changbin Du > > > > The terminal character '\0' should take into account into size of the > > string buffer.

Re: [PATCH v2] perf ftrace: Fix the buffer size in __write_tracing_file

2018-02-11 Thread Du, Changbin
Hi, On Mon, Feb 12, 2018 at 10:55:27AM +0900, Namhyung Kim wrote: > Hello, > > On Thu, Feb 08, 2018 at 04:13:20PM +0800, changbin...@intel.com wrote: > > From: Changbin Du > > > > The terminal character '\0' should take into account into size of the > > string buffer. Without this fix, the

Re: [PATCH v2] perf ftrace: Fix the buffer size in __write_tracing_file

2018-02-11 Thread Namhyung Kim
Hello, On Thu, Feb 08, 2018 at 04:13:20PM +0800, changbin...@intel.com wrote: > From: Changbin Du > > The terminal character '\0' should take into account into size of the > string buffer. Without this fix, the '--graph-funcs', '--nograph-funcs' > and '--trace-funcs'

Re: [PATCH v2] perf ftrace: Fix the buffer size in __write_tracing_file

2018-02-11 Thread Namhyung Kim
Hello, On Thu, Feb 08, 2018 at 04:13:20PM +0800, changbin...@intel.com wrote: > From: Changbin Du > > The terminal character '\0' should take into account into size of the > string buffer. Without this fix, the '--graph-funcs', '--nograph-funcs' > and '--trace-funcs' options didn't work as

[PATCH v2] perf ftrace: Fix the buffer size in __write_tracing_file

2018-02-08 Thread changbin . du
From: Changbin Du The terminal character '\0' should take into account into size of the string buffer. Without this fix, the '--graph-funcs', '--nograph-funcs' and '--trace-funcs' options didn't work as expected when the doesn't exist. If usersapce writes a non-terminated

[PATCH v2] perf ftrace: Fix the buffer size in __write_tracing_file

2018-02-08 Thread changbin . du
From: Changbin Du The terminal character '\0' should take into account into size of the string buffer. Without this fix, the '--graph-funcs', '--nograph-funcs' and '--trace-funcs' options didn't work as expected when the doesn't exist. If usersapce writes a non-terminated string, the kernel