Re: [PATCH v2] perf report: distinguish between inliners in the same function

2017-05-18 Thread Milian Wolff
On Mittwoch, 17. Mai 2017 08:13:16 CEST Namhyung Kim wrote: > On Tue, May 16, 2017 at 03:18:13PM +0200, Milian Wolff wrote: > > On Dienstag, 16. Mai 2017 02:53:32 CEST Namhyung Kim wrote: > > > On Mon, May 15, 2017 at 12:01:54PM +0200, Milian Wolff wrote: > > > > On Monday, May 15, 2017 3:21:58 AM

Re: [PATCH v2] perf report: distinguish between inliners in the same function

2017-05-18 Thread Milian Wolff
On Mittwoch, 17. Mai 2017 08:13:16 CEST Namhyung Kim wrote: > On Tue, May 16, 2017 at 03:18:13PM +0200, Milian Wolff wrote: > > On Dienstag, 16. Mai 2017 02:53:32 CEST Namhyung Kim wrote: > > > On Mon, May 15, 2017 at 12:01:54PM +0200, Milian Wolff wrote: > > > > On Monday, May 15, 2017 3:21:58 AM

Re: [PATCH v2] perf report: distinguish between inliners in the same function

2017-05-17 Thread Namhyung Kim
On Tue, May 16, 2017 at 03:18:13PM +0200, Milian Wolff wrote: > On Dienstag, 16. Mai 2017 02:53:32 CEST Namhyung Kim wrote: > > On Mon, May 15, 2017 at 12:01:54PM +0200, Milian Wolff wrote: > > > On Monday, May 15, 2017 3:21:58 AM CEST Namhyung Kim wrote: > > > > Hi Milian, > > > > > > > > On

Re: [PATCH v2] perf report: distinguish between inliners in the same function

2017-05-17 Thread Namhyung Kim
On Tue, May 16, 2017 at 03:18:13PM +0200, Milian Wolff wrote: > On Dienstag, 16. Mai 2017 02:53:32 CEST Namhyung Kim wrote: > > On Mon, May 15, 2017 at 12:01:54PM +0200, Milian Wolff wrote: > > > On Monday, May 15, 2017 3:21:58 AM CEST Namhyung Kim wrote: > > > > Hi Milian, > > > > > > > > On

Re: [PATCH v2] perf report: distinguish between inliners in the same function

2017-05-16 Thread Milian Wolff
On Dienstag, 16. Mai 2017 02:53:32 CEST Namhyung Kim wrote: > On Mon, May 15, 2017 at 12:01:54PM +0200, Milian Wolff wrote: > > On Monday, May 15, 2017 3:21:58 AM CEST Namhyung Kim wrote: > > > Hi Milian, > > > > > > On Sun, May 14, 2017 at 08:10:50PM +0200, Milian Wolff wrote: > > > > On

Re: [PATCH v2] perf report: distinguish between inliners in the same function

2017-05-16 Thread Milian Wolff
On Dienstag, 16. Mai 2017 02:53:32 CEST Namhyung Kim wrote: > On Mon, May 15, 2017 at 12:01:54PM +0200, Milian Wolff wrote: > > On Monday, May 15, 2017 3:21:58 AM CEST Namhyung Kim wrote: > > > Hi Milian, > > > > > > On Sun, May 14, 2017 at 08:10:50PM +0200, Milian Wolff wrote: > > > > On

Re: [PATCH v2] perf report: distinguish between inliners in the same function

2017-05-15 Thread Namhyung Kim
On Mon, May 15, 2017 at 12:01:54PM +0200, Milian Wolff wrote: > On Monday, May 15, 2017 3:21:58 AM CEST Namhyung Kim wrote: > > Hi Milian, > > > > On Sun, May 14, 2017 at 08:10:50PM +0200, Milian Wolff wrote: > > > On Freitag, 12. Mai 2017 15:01:29 CEST Namhyung Kim wrote: > > > > On Fri, May 12,

Re: [PATCH v2] perf report: distinguish between inliners in the same function

2017-05-15 Thread Namhyung Kim
On Mon, May 15, 2017 at 12:01:54PM +0200, Milian Wolff wrote: > On Monday, May 15, 2017 3:21:58 AM CEST Namhyung Kim wrote: > > Hi Milian, > > > > On Sun, May 14, 2017 at 08:10:50PM +0200, Milian Wolff wrote: > > > On Freitag, 12. Mai 2017 15:01:29 CEST Namhyung Kim wrote: > > > > On Fri, May 12,

Re: [PATCH v2] perf report: distinguish between inliners in the same function

2017-05-15 Thread Milian Wolff
On Monday, May 15, 2017 3:21:58 AM CEST Namhyung Kim wrote: > Hi Milian, > > On Sun, May 14, 2017 at 08:10:50PM +0200, Milian Wolff wrote: > > On Freitag, 12. Mai 2017 15:01:29 CEST Namhyung Kim wrote: > > > On Fri, May 12, 2017 at 12:37:01PM +0200, Milian Wolff wrote: > > > > On Mittwoch, 10.

Re: [PATCH v2] perf report: distinguish between inliners in the same function

2017-05-15 Thread Milian Wolff
On Monday, May 15, 2017 3:21:58 AM CEST Namhyung Kim wrote: > Hi Milian, > > On Sun, May 14, 2017 at 08:10:50PM +0200, Milian Wolff wrote: > > On Freitag, 12. Mai 2017 15:01:29 CEST Namhyung Kim wrote: > > > On Fri, May 12, 2017 at 12:37:01PM +0200, Milian Wolff wrote: > > > > On Mittwoch, 10.

Re: [PATCH v2] perf report: distinguish between inliners in the same function

2017-05-14 Thread Namhyung Kim
Hi Milian, On Sun, May 14, 2017 at 08:10:50PM +0200, Milian Wolff wrote: > On Freitag, 12. Mai 2017 15:01:29 CEST Namhyung Kim wrote: > > On Fri, May 12, 2017 at 12:37:01PM +0200, Milian Wolff wrote: > > > On Mittwoch, 10. Mai 2017 07:53:52 CEST Namhyung Kim wrote: > > > > Hi, > > > > > > > On

Re: [PATCH v2] perf report: distinguish between inliners in the same function

2017-05-14 Thread Namhyung Kim
Hi Milian, On Sun, May 14, 2017 at 08:10:50PM +0200, Milian Wolff wrote: > On Freitag, 12. Mai 2017 15:01:29 CEST Namhyung Kim wrote: > > On Fri, May 12, 2017 at 12:37:01PM +0200, Milian Wolff wrote: > > > On Mittwoch, 10. Mai 2017 07:53:52 CEST Namhyung Kim wrote: > > > > Hi, > > > > > > > On

Re: [PATCH v2] perf report: distinguish between inliners in the same function

2017-05-14 Thread Namhyung Kim
Hi Andi, On Fri, May 12, 2017 at 07:55:13AM -0700, Andi Kleen wrote: > Milian Wolff writes: > > > > I think I'm missing something, but isn't this what this function provides? > > The > > function above is now being used by the match_chain_inliner function below. > > > >

Re: [PATCH v2] perf report: distinguish between inliners in the same function

2017-05-14 Thread Namhyung Kim
Hi Andi, On Fri, May 12, 2017 at 07:55:13AM -0700, Andi Kleen wrote: > Milian Wolff writes: > > > > I think I'm missing something, but isn't this what this function provides? > > The > > function above is now being used by the match_chain_inliner function below. > > > > Ah, or do you mean for

Re: [PATCH v2] perf report: distinguish between inliners in the same function

2017-05-14 Thread Milian Wolff
On Freitag, 12. Mai 2017 15:01:29 CEST Namhyung Kim wrote: > On Fri, May 12, 2017 at 12:37:01PM +0200, Milian Wolff wrote: > > On Mittwoch, 10. Mai 2017 07:53:52 CEST Namhyung Kim wrote: > > > Hi, > > > > > On Wed, May 03, 2017 at 11:35:36PM +0200, Milian Wolff wrote: > > > > > > > > +static

Re: [PATCH v2] perf report: distinguish between inliners in the same function

2017-05-14 Thread Milian Wolff
On Freitag, 12. Mai 2017 15:01:29 CEST Namhyung Kim wrote: > On Fri, May 12, 2017 at 12:37:01PM +0200, Milian Wolff wrote: > > On Mittwoch, 10. Mai 2017 07:53:52 CEST Namhyung Kim wrote: > > > Hi, > > > > > On Wed, May 03, 2017 at 11:35:36PM +0200, Milian Wolff wrote: > > > > > > > > +static

Re: [PATCH v2] perf report: distinguish between inliners in the same function

2017-05-12 Thread Andi Kleen
Milian Wolff writes: > > I think I'm missing something, but isn't this what this function provides? > The > function above is now being used by the match_chain_inliner function below. > > Ah, or do you mean for code such as this: > > ~ > inline_func_1();

Re: [PATCH v2] perf report: distinguish between inliners in the same function

2017-05-12 Thread Andi Kleen
Milian Wolff writes: > > I think I'm missing something, but isn't this what this function provides? > The > function above is now being used by the match_chain_inliner function below. > > Ah, or do you mean for code such as this: > > ~ > inline_func_1(); inline_func_2(); This could be

Re: [PATCH v2] perf report: distinguish between inliners in the same function

2017-05-12 Thread Namhyung Kim
On Fri, May 12, 2017 at 12:37:01PM +0200, Milian Wolff wrote: > On Mittwoch, 10. Mai 2017 07:53:52 CEST Namhyung Kim wrote: > > Hi, > > > > On Wed, May 03, 2017 at 11:35:36PM +0200, Milian Wolff wrote: > > > > > > +static enum match_result match_chain_srcline(struct callchain_cursor_node > > >

Re: [PATCH v2] perf report: distinguish between inliners in the same function

2017-05-12 Thread Namhyung Kim
On Fri, May 12, 2017 at 12:37:01PM +0200, Milian Wolff wrote: > On Mittwoch, 10. Mai 2017 07:53:52 CEST Namhyung Kim wrote: > > Hi, > > > > On Wed, May 03, 2017 at 11:35:36PM +0200, Milian Wolff wrote: > > > > > > +static enum match_result match_chain_srcline(struct callchain_cursor_node > > >

Re: [PATCH v2] perf report: distinguish between inliners in the same function

2017-05-12 Thread Milian Wolff
On Mittwoch, 10. Mai 2017 07:53:52 CEST Namhyung Kim wrote: > Hi, > > On Wed, May 03, 2017 at 11:35:36PM +0200, Milian Wolff wrote: > > +static enum match_result match_chain_srcline(struct callchain_cursor_node > > *node, + struct callchain_list > >

Re: [PATCH v2] perf report: distinguish between inliners in the same function

2017-05-12 Thread Milian Wolff
On Mittwoch, 10. Mai 2017 07:53:52 CEST Namhyung Kim wrote: > Hi, > > On Wed, May 03, 2017 at 11:35:36PM +0200, Milian Wolff wrote: > > +static enum match_result match_chain_srcline(struct callchain_cursor_node > > *node, + struct callchain_list > >

Re: [PATCH v2] perf report: distinguish between inliners in the same function

2017-05-09 Thread Namhyung Kim
Hi, On Wed, May 03, 2017 at 11:35:36PM +0200, Milian Wolff wrote: > When different functions get inlined into the same function, we > want to show them individually in the reports. But when we group by > function, we would aggregate all IPs and would only keep the first > one in that function.

Re: [PATCH v2] perf report: distinguish between inliners in the same function

2017-05-09 Thread Namhyung Kim
Hi, On Wed, May 03, 2017 at 11:35:36PM +0200, Milian Wolff wrote: > When different functions get inlined into the same function, we > want to show them individually in the reports. But when we group by > function, we would aggregate all IPs and would only keep the first > one in that function.

Re: [PATCH v2] perf report: distinguish between inliners in the same function

2017-05-08 Thread Arnaldo Carvalho de Melo
Em Mon, May 08, 2017 at 10:45:18AM +0200, Milian Wolff escreveu: > On Mittwoch, 3. Mai 2017 23:35:36 CEST Milian Wolff wrote: > > When different functions get inlined into the same function, we > > want to show them individually in the reports. But when we group by > > function, we would aggregate

Re: [PATCH v2] perf report: distinguish between inliners in the same function

2017-05-08 Thread Arnaldo Carvalho de Melo
Em Mon, May 08, 2017 at 10:45:18AM +0200, Milian Wolff escreveu: > On Mittwoch, 3. Mai 2017 23:35:36 CEST Milian Wolff wrote: > > When different functions get inlined into the same function, we > > want to show them individually in the reports. But when we group by > > function, we would aggregate

Re: [PATCH v2] perf report: distinguish between inliners in the same function

2017-05-08 Thread Milian Wolff
On Mittwoch, 3. Mai 2017 23:35:36 CEST Milian Wolff wrote: > When different functions get inlined into the same function, we > want to show them individually in the reports. But when we group by > function, we would aggregate all IPs and would only keep the first > one in that function. E.g. for

Re: [PATCH v2] perf report: distinguish between inliners in the same function

2017-05-08 Thread Milian Wolff
On Mittwoch, 3. Mai 2017 23:35:36 CEST Milian Wolff wrote: > When different functions get inlined into the same function, we > want to show them individually in the reports. But when we group by > function, we would aggregate all IPs and would only keep the first > one in that function. E.g. for

[PATCH v2] perf report: distinguish between inliners in the same function

2017-05-03 Thread Milian Wolff
When different functions get inlined into the same function, we want to show them individually in the reports. But when we group by function, we would aggregate all IPs and would only keep the first one in that function. E.g. for C++ code like the following: ~ #include #include #include

[PATCH v2] perf report: distinguish between inliners in the same function

2017-05-03 Thread Milian Wolff
When different functions get inlined into the same function, we want to show them individually in the reports. But when we group by function, we would aggregate all IPs and would only keep the first one in that function. E.g. for C++ code like the following: ~ #include #include #include