Re: [PATCH v2] perf script python: Fix dict reference counting

2018-07-11 Thread Namhyung Kim
Hell, On Mon, Jul 09, 2018 at 01:59:50PM +0300, Janne Huttunen wrote: > The dictionaries are attached to the parameter tuple that steals > the references and takes care of releasing them when appropriate. > The code should not decrement the reference counts explicitly. > E.g. if libpython has been

Re: [PATCH v2] perf script python: Fix dict reference counting

2018-07-09 Thread Jiri Olsa
On Mon, Jul 09, 2018 at 01:59:50PM +0300, Janne Huttunen wrote: > The dictionaries are attached to the parameter tuple that steals > the references and takes care of releasing them when appropriate. > The code should not decrement the reference counts explicitly. > E.g. if libpython has been built

[PATCH v2] perf script python: Fix dict reference counting

2018-07-09 Thread Janne Huttunen
The dictionaries are attached to the parameter tuple that steals the references and takes care of releasing them when appropriate. The code should not decrement the reference counts explicitly. E.g. if libpython has been built with reference debugging enabled, the superfluous DECREFs will trigger t