Re: [PATCH v2] perf scripts python: Add Python 3 support to exported-sql-viewer.py

2019-01-21 Thread seeteena
On 01/19/2019 06:15 AM, Tony Jones wrote: On 1/17/19 1:45 AM, Seeteena Thoufeek wrote: +if sys.version_info[0] < 3: +import cPickle +else: +import _pickle as cPickle Do you really need this? pickle is already in Python2. Also, did you test these changes on Python3? I think you'll

Re: [PATCH v2] perf scripts python: Add Python 3 support to exported-sql-viewer.py

2019-01-20 Thread Tony Jones
On 1/20/19 11:27 AM, Jonathan Corbet wrote: > On Fri, 18 Jan 2019 16:45:04 -0800 > Tony Jones wrote: > >> On 1/17/19 1:45 AM, Seeteena Thoufeek wrote: >> >>> +if sys.version_info[0] < 3: >>> +import cPickle >>> +else: >>> +import _pickle as cPickle >> >> Do you really need this? >> >> p

Re: [PATCH v2] perf scripts python: Add Python 3 support to exported-sql-viewer.py

2019-01-20 Thread Jonathan Corbet
On Fri, 18 Jan 2019 16:45:04 -0800 Tony Jones wrote: > On 1/17/19 1:45 AM, Seeteena Thoufeek wrote: > > > +if sys.version_info[0] < 3: > > +import cPickle > > +else: > > +import _pickle as cPickle > > Do you really need this? > > pickle is already in Python2. Did you mean in Python3

Re: [PATCH v2] perf scripts python: Add Python 3 support to exported-sql-viewer.py

2019-01-18 Thread Tony Jones
On 1/17/19 1:45 AM, Seeteena Thoufeek wrote: > +if sys.version_info[0] < 3: > +import cPickle > +else: > +import _pickle as cPickle Do you really need this? pickle is already in Python2. Also, did you test these changes on Python3? I think you'll find you also need the following hunk

[PATCH v2] perf scripts python: Add Python 3 support to exported-sql-viewer.py

2019-01-17 Thread Seeteena Thoufeek
Support both Python 2 and Python 3 in exported-sql-viewer.py. ``print`` is now a function rather than a statement. This should have no functional change. Add support of _pickle module in Python3 Signed-off-by: Seeteena Thoufeek Reviewed-by: Ravi Bangoria --- tools/perf/scripts/python/exported-