Re: [PATCH v2] perf tools: avoid sample_reg_masks being const + weak

2019-09-30 Thread Ian Rogers
Apologies for that. I've addressed in v3 but only tested for riscv. There is potential for additional tidy up related to this change, let me know what would be appropriate. Thanks, Ian On Mon, Sep 30, 2019 at 5:42 AM Jiri Olsa wrote: > > On Mon, Sep 30, 2019 at 09:23:35AM -0300, Arnaldo

Re: [PATCH v2] perf tools: avoid sample_reg_masks being const + weak

2019-09-30 Thread Jiri Olsa
On Mon, Sep 30, 2019 at 09:23:35AM -0300, Arnaldo Carvalho de Melo wrote: SNIP > CC /tmp/build/perf/util/lzma.o > CC /tmp/build/perf/util/demangle-java.o > CC /tmp/build/perf/util/demangle-rust.o > CC /tmp/build/perf/util/jitdump.o > CC

Re: [PATCH v2] perf tools: avoid sample_reg_masks being const + weak

2019-09-30 Thread Arnaldo Carvalho de Melo
Em Sun, Sep 29, 2019 at 11:05:14PM +0200, Jiri Olsa escreveu: > On Fri, Sep 27, 2019 at 02:43:41PM -0700, Ian Rogers wrote: > > Being const + weak breaks with some compilers that constant-propagate > > from the weak symbol. This behavior is outside of the specification, but > > in LLVM is chosen

Re: [PATCH v2] perf tools: avoid sample_reg_masks being const + weak

2019-09-30 Thread Arnaldo Carvalho de Melo
Em Sun, Sep 29, 2019 at 11:05:14PM +0200, Jiri Olsa escreveu: > On Fri, Sep 27, 2019 at 02:43:41PM -0700, Ian Rogers wrote: > > Being const + weak breaks with some compilers that constant-propagate > > from the weak symbol. This behavior is outside of the specification, but > > in LLVM is chosen

Re: [PATCH v2] perf tools: avoid sample_reg_masks being const + weak

2019-09-29 Thread Jiri Olsa
On Fri, Sep 27, 2019 at 02:43:41PM -0700, Ian Rogers wrote: > Being const + weak breaks with some compilers that constant-propagate > from the weak symbol. This behavior is outside of the specification, but > in LLVM is chosen to match GCC's behavior. > > LLVM's implementation was set in this

[PATCH v2] perf tools: avoid sample_reg_masks being const + weak

2019-09-27 Thread Ian Rogers
Being const + weak breaks with some compilers that constant-propagate from the weak symbol. This behavior is outside of the specification, but in LLVM is chosen to match GCC's behavior. LLVM's implementation was set in this patch: