Re: [PATCH v2] perf tools: fix off-by-one error in maps

2014-10-14 Thread Arnaldo Carvalho de Melo
Em Tue, Oct 14, 2014 at 09:03:02PM +0200, Stephane Eranian escreveu: > On Tue, Oct 14, 2014 at 8:58 PM, Arnaldo Carvalho de Melo > > struct vm_area_struct { > > /* The first cache line has the info for VMA tree walking. */ > > unsigned long vm_start; /* Our start address wi

Re: [PATCH v2] perf tools: fix off-by-one error in maps

2014-10-14 Thread Arnaldo Carvalho de Melo
Em Tue, Oct 07, 2014 at 02:47:19PM +0900, Namhyung Kim escreveu: > Hi Stephane, > > On Mon, 6 Oct 2014 10:35:32 +0200, Stephane Eranian wrote: > > This patch fixes off-by-one errors in the management of maps. > > A map is defined by start address and length as implemented by map__new(): > > > > ma

Re: [PATCH v2] perf tools: fix off-by-one error in maps

2014-10-14 Thread Stephane Eranian
On Tue, Oct 14, 2014 at 8:58 PM, Arnaldo Carvalho de Melo wrote: > Em Tue, Oct 07, 2014 at 05:17:12PM +0200, Stephane Eranian escreveu: >> On Tue, Oct 7, 2014 at 5:10 PM, Arnaldo Carvalho de Melo >> wrote: >> > Em Tue, Oct 07, 2014 at 04:17:41PM +0200, Stephane Eranian escreveu: >> >> On Tue, Oct

Re: [PATCH v2] perf tools: fix off-by-one error in maps

2014-10-14 Thread Arnaldo Carvalho de Melo
Em Tue, Oct 07, 2014 at 05:17:12PM +0200, Stephane Eranian escreveu: > On Tue, Oct 7, 2014 at 5:10 PM, Arnaldo Carvalho de Melo > wrote: > > Em Tue, Oct 07, 2014 at 04:17:41PM +0200, Stephane Eranian escreveu: > >> On Tue, Oct 7, 2014 at 4:00 PM, Arnaldo Carvalho de Melo > >> >> +++ b/tools/perf/u

Re: [PATCH v2] perf tools: fix off-by-one error in maps

2014-10-08 Thread Arnaldo Carvalho de Melo
Em Tue, Oct 07, 2014 at 01:58:38PM -0500, Chuck Ebbert escreveu: > On Tue, 7 Oct 2014 11:00:50 -0300 > Arnaldo Carvalho de Melo wrote: > > > I keep thinking that this change is making things unclear. > > > > I.e. the _start_ of a map (map->start) is _in_ the map, and the _end_ > > of a map (map-

Re: [PATCH v2] perf tools: fix off-by-one error in maps

2014-10-07 Thread Chuck Ebbert
On Tue, 7 Oct 2014 11:00:50 -0300 Arnaldo Carvalho de Melo wrote: > I keep thinking that this change is making things unclear. > > I.e. the _start_ of a map (map->start) is _in_ the map, and the _end_ > of a map (map->end) is _in_ the map as well. > > if (addr > m->end) > > is shorter th

Re: [PATCH v2] perf tools: fix off-by-one error in maps

2014-10-07 Thread Stephane Eranian
On Tue, Oct 7, 2014 at 5:10 PM, Arnaldo Carvalho de Melo wrote: > Em Tue, Oct 07, 2014 at 04:17:41PM +0200, Stephane Eranian escreveu: >> On Tue, Oct 7, 2014 at 4:00 PM, Arnaldo Carvalho de Melo >> wrote: >> > Em Tue, Oct 07, 2014 at 02:47:19PM +0900, Namhyung Kim escreveu: >> >> On Mon, 6 Oct 20

Re: [PATCH v2] perf tools: fix off-by-one error in maps

2014-10-07 Thread Arnaldo Carvalho de Melo
Em Tue, Oct 07, 2014 at 04:17:41PM +0200, Stephane Eranian escreveu: > On Tue, Oct 7, 2014 at 4:00 PM, Arnaldo Carvalho de Melo > wrote: > > Em Tue, Oct 07, 2014 at 02:47:19PM +0900, Namhyung Kim escreveu: > >> On Mon, 6 Oct 2014 10:35:32 +0200, Stephane Eranian wrote: > >> > This patch fixes off-

Re: [PATCH v2] perf tools: fix off-by-one error in maps

2014-10-07 Thread Stephane Eranian
On Tue, Oct 7, 2014 at 4:00 PM, Arnaldo Carvalho de Melo wrote: > Em Tue, Oct 07, 2014 at 02:47:19PM +0900, Namhyung Kim escreveu: >> On Mon, 6 Oct 2014 10:35:32 +0200, Stephane Eranian wrote: >> > This patch fixes off-by-one errors in the management of maps. >> > A map is defined by start address

Re: [PATCH v2] perf tools: fix off-by-one error in maps

2014-10-07 Thread Arnaldo Carvalho de Melo
Em Tue, Oct 07, 2014 at 02:47:19PM +0900, Namhyung Kim escreveu: > On Mon, 6 Oct 2014 10:35:32 +0200, Stephane Eranian wrote: > > This patch fixes off-by-one errors in the management of maps. > > A map is defined by start address and length as implemented by map__new(): > > map__init(map, type, st

Re: [PATCH v2] perf tools: fix off-by-one error in maps

2014-10-07 Thread Stephane Eranian
On Tue, Oct 7, 2014 at 7:47 AM, Namhyung Kim wrote: > Hi Stephane, > > On Mon, 6 Oct 2014 10:35:32 +0200, Stephane Eranian wrote: >> This patch fixes off-by-one errors in the management of maps. >> A map is defined by start address and length as implemented by map__new(): >> >> map__init(map, type

Re: [PATCH v2] perf tools: fix off-by-one error in maps

2014-10-06 Thread Namhyung Kim
Hi Stephane, On Mon, 6 Oct 2014 10:35:32 +0200, Stephane Eranian wrote: > This patch fixes off-by-one errors in the management of maps. > A map is defined by start address and length as implemented by map__new(): > > map__init(map, type, start, start + len, pgoff, dso); > > map->start = addr; > ma

[PATCH v2] perf tools: fix off-by-one error in maps

2014-10-06 Thread Stephane Eranian
This patch fixes off-by-one errors in the management of maps. A map is defined by start address and length as implemented by map__new(): map__init(map, type, start, start + len, pgoff, dso); map->start = addr; map->end = end; Consequently, the actual address range is ]start; end[ map->end is th