Re: [PATCH v2] pinctrl: mediatek: Free eint data on failure

2020-10-01 Thread Enric Balletbo i Serra
Hi, On 1/10/20 9:58, Linus Walleij wrote: > On Wed, Sep 30, 2020 at 6:33 PM Sean Wang wrote: >> On Wed, Sep 30, 2020 at 1:47 AM Linus Walleij >> wrote: >>> On Sun, Sep 27, 2020 at 7:57 PM Sean Wang wrote: >>> v2 seems the same with v1 or I was missing something. I just thought w

Re: [PATCH v2] pinctrl: mediatek: Free eint data on failure

2020-10-01 Thread Linus Walleij
On Wed, Sep 30, 2020 at 6:33 PM Sean Wang wrote: > On Wed, Sep 30, 2020 at 1:47 AM Linus Walleij > wrote: > > On Sun, Sep 27, 2020 at 7:57 PM Sean Wang wrote: > > > > > v2 seems the same with v1 or I was missing something. > > > > > > I just thought we call devm_ioremap_release to explicitly to

Re: [PATCH v2] pinctrl: mediatek: Free eint data on failure

2020-09-30 Thread Sean Wang
On Wed, Sep 30, 2020 at 1:47 AM Linus Walleij wrote: > > On Sun, Sep 27, 2020 at 7:57 PM Sean Wang wrote: > > > v2 seems the same with v1 or I was missing something. > > > > I just thought we call devm_ioremap_release to explicitly to free > > resource when a certain failure occurs after > > devm

Re: [PATCH v2] pinctrl: mediatek: Free eint data on failure

2020-09-30 Thread Linus Walleij
On Sun, Sep 27, 2020 at 7:57 PM Sean Wang wrote: > v2 seems the same with v1 or I was missing something. > > I just thought we call devm_ioremap_release to explicitly to free > resource when a certain failure occurs after > devm_ioremap_resource? What is the semantics around mtk_build_eint()? I

Re: [PATCH v2] pinctrl: mediatek: Free eint data on failure

2020-09-27 Thread Sean Wang
Hi, Enric v2 seems the same with v1 or I was missing something. I just thought we call devm_ioremap_release to explicitly to free resource when a certain failure occurs after devm_ioremap_resource? thanks, Sean On Tue, Sep 15, 2020 at 5:38 AM Enric Balletbo i Serra wrote: > > Hi Linus, > > On

Re: [PATCH v2] pinctrl: mediatek: Free eint data on failure

2020-09-15 Thread Enric Balletbo i Serra
Hi Linus, On 21/8/20 9:54, Enric Balletbo i Serra wrote: > The pinctrl driver can work without the EINT resource, but, if it is > expected to have this resource but the mtk_build_eint() function fails > after allocating their data (because can't get the resource or can't map > the irq), the data i

[PATCH v2] pinctrl: mediatek: Free eint data on failure

2020-08-21 Thread Enric Balletbo i Serra
The pinctrl driver can work without the EINT resource, but, if it is expected to have this resource but the mtk_build_eint() function fails after allocating their data (because can't get the resource or can't map the irq), the data is not freed and you end with a NULL pointer dereference. Fix this