Re: [PATCH v2] pinctrl: tegra: use signed bitfields for optional fields

2015-03-19 Thread Linus Walleij
On Mon, Mar 16, 2015 at 10:42 PM, Stefan Agner wrote: > Optional fields are set to -1 by various preprocessor macros. Make > sure the fields can actually store them. > > Signed-off-by: Stefan Agner Patch applied with Stephen's ACK/Test tags. Yours, Linus Walleij -- To unsubscribe from this lis

Re: [PATCH v2] pinctrl: tegra: use signed bitfields for optional fields

2015-03-16 Thread Stephen Warren
On 03/16/2015 03:42 PM, Stefan Agner wrote: Optional fields are set to -1 by various preprocessor macros. Make sure the fields can actually store them. This seems fine to me. I suppose there is a small risk that the old code let some invalid configurations pass whereas this new code will rejec

[PATCH v2] pinctrl: tegra: use signed bitfields for optional fields

2015-03-16 Thread Stefan Agner
Optional fields are set to -1 by various preprocessor macros. Make sure the fields can actually store them. Signed-off-by: Stefan Agner --- With that, sizes are back to normal: textdata bss dec hex filename 5406 180 1558715d3 drivers/pinctrl/pinctrl-tegra-