Re: [PATCH v2] printk: fix deadlock when kernel panic

2021-02-09 Thread Sergey Senozhatsky
On (21/02/09 10:19), Petr Mladek wrote: > On Sat 2021-02-06 13:41:24, Muchun Song wrote: [..] > What about the following commit message? It uses imperative language > and explains that the patch just prevents the deadlock. It removes > some details. The diagram is better than many words. > > >

Re: [External] Re: [PATCH v2] printk: fix deadlock when kernel panic

2021-02-09 Thread Sergey Senozhatsky
On (21/02/09 09:39), Petr Mladek wrote: > > > So then this never re-inits the safe_read_lock? > > Yes, but it will also not cause the deadlock. Right. > I prefer this approach. It is straightforward because it handles > read_lock the same way as logbuf_lock. I'm fine with that approach, but

Re: [External] Re: [PATCH v2] printk: fix deadlock when kernel panic

2021-02-09 Thread Muchun Song
On Tue, Feb 9, 2021 at 5:19 PM Petr Mladek wrote: > > On Sat 2021-02-06 13:41:24, Muchun Song wrote: > > We found a deadlock bug on our server when the kernel panic. It can be > > described in the following diagram. > > > > CPU0: CPU1: > > panic

Re: [PATCH v2] printk: fix deadlock when kernel panic

2021-02-09 Thread Petr Mladek
On Sat 2021-02-06 13:41:24, Muchun Song wrote: > We found a deadlock bug on our server when the kernel panic. It can be > described in the following diagram. > > CPU0: CPU1: > panic rcu_dump_cpu_stacks >

Re: [External] Re: [PATCH v2] printk: fix deadlock when kernel panic

2021-02-09 Thread Petr Mladek
On Mon 2021-02-08 23:40:07, Muchun Song wrote: > On Mon, Feb 8, 2021 at 9:12 PM Sergey Senozhatsky > wrote: > > > > On (21/02/08 16:49), Muchun Song wrote: > > > On Mon, Feb 8, 2021 at 2:38 PM Sergey Senozhatsky > > > wrote: > > > > > > > > On (21/02/06 13:41), Muchun Song wrote: > > > > > We

Re: [External] Re: [PATCH v2] printk: fix deadlock when kernel panic

2021-02-08 Thread Muchun Song
On Mon, Feb 8, 2021 at 9:12 PM Sergey Senozhatsky wrote: > > On (21/02/08 16:49), Muchun Song wrote: > > On Mon, Feb 8, 2021 at 2:38 PM Sergey Senozhatsky > > wrote: > > > > > > On (21/02/06 13:41), Muchun Song wrote: > > > > We found a deadlock bug on our server when the kernel panic. It can be

Re: [External] Re: [PATCH v2] printk: fix deadlock when kernel panic

2021-02-08 Thread Sergey Senozhatsky
On (21/02/08 16:49), Muchun Song wrote: > On Mon, Feb 8, 2021 at 2:38 PM Sergey Senozhatsky > wrote: > > > > On (21/02/06 13:41), Muchun Song wrote: > > > We found a deadlock bug on our server when the kernel panic. It can be > > > described in the following diagram. > > > > > > CPU0:

Re: [External] Re: [PATCH v2] printk: fix deadlock when kernel panic

2021-02-08 Thread Muchun Song
On Mon, Feb 8, 2021 at 2:38 PM Sergey Senozhatsky wrote: > > On (21/02/06 13:41), Muchun Song wrote: > > We found a deadlock bug on our server when the kernel panic. It can be > > described in the following diagram. > > > > CPU0: CPU1: > > panic

Re: [PATCH v2] printk: fix deadlock when kernel panic

2021-02-07 Thread Sergey Senozhatsky
On (21/02/06 13:41), Muchun Song wrote: > We found a deadlock bug on our server when the kernel panic. It can be > described in the following diagram. > > CPU0: CPU1: > panic rcu_dump_cpu_stacks >

[PATCH v2] printk: fix deadlock when kernel panic

2021-02-05 Thread Muchun Song
We found a deadlock bug on our server when the kernel panic. It can be described in the following diagram. CPU0: CPU1: panic rcu_dump_cpu_stacks kdump_nmi_shootdown_cpus