Re: [PATCH v2] printk: help pr_debug and pr_devel to optimize out arguments

2015-12-09 Thread Joe Perches
On Wed, 2015-12-09 at 12:52 +0100, Arnd Bergmann wrote: > On Friday 04 December 2015 16:51:42 Aaron Conole wrote: > > --- a/include/linux/printk.h > > +++ b/include/linux/printk.h > > @@ -106,13 +106,14 @@ struct va_format { > >   > >  /* > >   * Dummy printk for disabled debugging statements to

Re: [PATCH v2] printk: help pr_debug and pr_devel to optimize out arguments

2015-12-09 Thread Aaron Conole
Arnd Bergmann writes: > On Friday 04 December 2015 16:51:42 Aaron Conole wrote: >> --- a/include/linux/printk.h >> +++ b/include/linux/printk.h >> @@ -106,13 +106,14 @@ struct va_format { >> >> /* >> * Dummy printk for disabled debugging statements to use whilst maintaining >> - * gcc's

Re: [PATCH v2] printk: help pr_debug and pr_devel to optimize out arguments

2015-12-09 Thread Arnd Bergmann
On Friday 04 December 2015 16:51:42 Aaron Conole wrote: > --- a/include/linux/printk.h > +++ b/include/linux/printk.h > @@ -106,13 +106,14 @@ struct va_format { > > /* > * Dummy printk for disabled debugging statements to use whilst maintaining > - * gcc's format and side-effect checking. > +

Re: [PATCH v2] printk: help pr_debug and pr_devel to optimize out arguments

2015-12-09 Thread Arnd Bergmann
On Friday 04 December 2015 16:51:42 Aaron Conole wrote: > --- a/include/linux/printk.h > +++ b/include/linux/printk.h > @@ -106,13 +106,14 @@ struct va_format { > > /* > * Dummy printk for disabled debugging statements to use whilst maintaining > - * gcc's format and side-effect checking. > +

Re: [PATCH v2] printk: help pr_debug and pr_devel to optimize out arguments

2015-12-09 Thread Aaron Conole
Arnd Bergmann writes: > On Friday 04 December 2015 16:51:42 Aaron Conole wrote: >> --- a/include/linux/printk.h >> +++ b/include/linux/printk.h >> @@ -106,13 +106,14 @@ struct va_format { >> >> /* >> * Dummy printk for disabled debugging statements to use whilst maintaining >>

Re: [PATCH v2] printk: help pr_debug and pr_devel to optimize out arguments

2015-12-09 Thread Joe Perches
On Wed, 2015-12-09 at 12:52 +0100, Arnd Bergmann wrote: > On Friday 04 December 2015 16:51:42 Aaron Conole wrote: > > --- a/include/linux/printk.h > > +++ b/include/linux/printk.h > > @@ -106,13 +106,14 @@ struct va_format { > >   > >  /* > >   * Dummy printk for disabled debugging statements to

[PATCH v2] printk: help pr_debug and pr_devel to optimize out arguments

2015-12-04 Thread Aaron Conole
Currently, pr_debug and pr_devel will not elide function call arguments appearing in calls to the no_printk for these macros. This is because all side effects must be honored before proceeding to the 0-value assignment in no_printk. The behavior is contrary to documentation found in the

[PATCH v2] printk: help pr_debug and pr_devel to optimize out arguments

2015-12-04 Thread Aaron Conole
Currently, pr_debug and pr_devel will not elide function call arguments appearing in calls to the no_printk for these macros. This is because all side effects must be honored before proceeding to the 0-value assignment in no_printk. The behavior is contrary to documentation found in the