Re: [PATCH v2] pstore: Adjust buffer size for compression for smaller registered buffers

2013-09-12 Thread Aruna Balakrishnaiah
On Thursday 12 September 2013 11:13 PM, Luck, Tony wrote: + default: + cmpr = 60; + break; + } Is this the right "default"? It may be a good choice for a backend with a really tiny buffer (1 ... 999). But less good for a (theoretical) backend with a la

RE: [PATCH v2] pstore: Adjust buffer size for compression for smaller registered buffers

2013-09-12 Thread Luck, Tony
+ default: + cmpr = 60; + break; + } Is this the right "default"? It may be a good choice for a backend with a really tiny buffer (1 ... 999). But less good for a (theoretical) backend with a larger buffer (10001 ... infinity and beyond). Which are you

RE: [PATCH v2] pstore: Adjust buffer size for compression for smaller registered buffers

2013-09-12 Thread Seiji Aguchi
t; linux-kernel@vger.kernel.org; keesc...@chromium.org > Cc: jkeni...@linux.vnet.ibm.com; mah...@linux.vnet.ibm.com; > cbouatmai...@gmail.com; ana...@in.ibm.com; ccr...@android.com > Subject: [PATCH v2] pstore: Adjust buffer size for compression for smaller > registered buffers > > When ba

[PATCH v2] pstore: Adjust buffer size for compression for smaller registered buffers

2013-09-11 Thread Aruna Balakrishnaiah
When backends (ex: efivars) have smaller registered buffers, the big_oops_buf is quite too big for them as number of repeated occurences in the text captured will be less. Patch takes care of adjusting the buffer size based on the registered buffer size. cmpr values has been arrived after doing exp