Re: [PATCH v2] pstore: Fail to unlink if a driver has not defined pstore_erase

2013-06-26 Thread Aruna Balakrishnaiah
On Tuesday 25 June 2013 10:40 PM, Tony Luck wrote: On Tue, Jun 25, 2013 at 9:41 AM, Kees Cook wrote: On Tue, Jun 25, 2013 at 2:03 AM, Aruna Balakrishnaiah wrote: pstore_erase is used to erase the record from the persistent store. So if a driver has not defined pstore_erase callback return

Re: [PATCH v2] pstore: Fail to unlink if a driver has not defined pstore_erase

2013-06-26 Thread Aruna Balakrishnaiah
On Tuesday 25 June 2013 10:40 PM, Tony Luck wrote: On Tue, Jun 25, 2013 at 9:41 AM, Kees Cook keesc...@chromium.org wrote: On Tue, Jun 25, 2013 at 2:03 AM, Aruna Balakrishnaiah ar...@linux.vnet.ibm.com wrote: pstore_erase is used to erase the record from the persistent store. So if a driver

Re: [PATCH v2] pstore: Fail to unlink if a driver has not defined pstore_erase

2013-06-25 Thread Tony Luck
On Tue, Jun 25, 2013 at 9:41 AM, Kees Cook wrote: > On Tue, Jun 25, 2013 at 2:03 AM, Aruna Balakrishnaiah > wrote: >> pstore_erase is used to erase the record from the persistent store. >> So if a driver has not defined pstore_erase callback return How do people manage devices like this? With

Re: [PATCH v2] pstore: Fail to unlink if a driver has not defined pstore_erase

2013-06-25 Thread Kees Cook
On Tue, Jun 25, 2013 at 2:03 AM, Aruna Balakrishnaiah wrote: > pstore_erase is used to erase the record from the persistent store. > So if a driver has not defined pstore_erase callback return > -EPERM instead of unlinking a file as deleting the file without > erasing its record in persistent

[PATCH v2] pstore: Fail to unlink if a driver has not defined pstore_erase

2013-06-25 Thread Aruna Balakrishnaiah
pstore_erase is used to erase the record from the persistent store. So if a driver has not defined pstore_erase callback return -EPERM instead of unlinking a file as deleting the file without erasing its record in persistent store will give a wrong impression to customers. Signed-off-by: Aruna

[PATCH v2] pstore: Fail to unlink if a driver has not defined pstore_erase

2013-06-25 Thread Aruna Balakrishnaiah
pstore_erase is used to erase the record from the persistent store. So if a driver has not defined pstore_erase callback return -EPERM instead of unlinking a file as deleting the file without erasing its record in persistent store will give a wrong impression to customers. Signed-off-by: Aruna

Re: [PATCH v2] pstore: Fail to unlink if a driver has not defined pstore_erase

2013-06-25 Thread Kees Cook
On Tue, Jun 25, 2013 at 2:03 AM, Aruna Balakrishnaiah ar...@linux.vnet.ibm.com wrote: pstore_erase is used to erase the record from the persistent store. So if a driver has not defined pstore_erase callback return -EPERM instead of unlinking a file as deleting the file without erasing its

Re: [PATCH v2] pstore: Fail to unlink if a driver has not defined pstore_erase

2013-06-25 Thread Tony Luck
On Tue, Jun 25, 2013 at 9:41 AM, Kees Cook keesc...@chromium.org wrote: On Tue, Jun 25, 2013 at 2:03 AM, Aruna Balakrishnaiah ar...@linux.vnet.ibm.com wrote: pstore_erase is used to erase the record from the persistent store. So if a driver has not defined pstore_erase callback return How do