Re: [PATCH v2] pwm-backlight: allow for non-increasing brightness levels

2013-10-18 Thread Mike Dunn
On 10/18/2013 12:46 AM, Thierry Reding wrote: > On Sun, Sep 22, 2013 at 09:59:56AM -0700, Mike Dunn wrote: >> Currently the driver assumes that the values specified in the >> brightness-levels device tree property increase as they are parsed from >> left to right. But boards that invert the

Re: [PATCH v2] pwm-backlight: allow for non-increasing brightness levels

2013-10-18 Thread Thierry Reding
On Sun, Sep 22, 2013 at 09:59:56AM -0700, Mike Dunn wrote: > Currently the driver assumes that the values specified in the > brightness-levels device tree property increase as they are parsed from > left to right. But boards that invert the signal between the PWM output > and the backlight will

Re: [PATCH v2] pwm-backlight: allow for non-increasing brightness levels

2013-10-18 Thread Thierry Reding
On Sun, Sep 22, 2013 at 09:59:56AM -0700, Mike Dunn wrote: Currently the driver assumes that the values specified in the brightness-levels device tree property increase as they are parsed from left to right. But boards that invert the signal between the PWM output and the backlight will need

Re: [PATCH v2] pwm-backlight: allow for non-increasing brightness levels

2013-10-18 Thread Mike Dunn
On 10/18/2013 12:46 AM, Thierry Reding wrote: On Sun, Sep 22, 2013 at 09:59:56AM -0700, Mike Dunn wrote: Currently the driver assumes that the values specified in the brightness-levels device tree property increase as they are parsed from left to right. But boards that invert the signal

Re: [PATCH v2] pwm-backlight: allow for non-increasing brightness levels

2013-09-29 Thread Laurent Pinchart
Hi Jingoo, On Friday 27 September 2013 12:28:21 Jingoo Han wrote: > On Thursday, September 26, 2013 9:08 PM, Tomi Valkeinen wrote: > > On 26/09/13 14:51, Thierry Reding wrote: > > > On Thu, Sep 26, 2013 at 01:03:06PM +0300, Tomi Valkeinen wrote: > > > [...] > > > > > >> But if you and Thierry

Re: [PATCH v2] pwm-backlight: allow for non-increasing brightness levels

2013-09-29 Thread Laurent Pinchart
Hi Jingoo, On Friday 27 September 2013 12:28:21 Jingoo Han wrote: On Thursday, September 26, 2013 9:08 PM, Tomi Valkeinen wrote: On 26/09/13 14:51, Thierry Reding wrote: On Thu, Sep 26, 2013 at 01:03:06PM +0300, Tomi Valkeinen wrote: [...] But if you and Thierry think this version

Re: [PATCH v2] pwm-backlight: allow for non-increasing brightness levels

2013-09-26 Thread Jingoo Han
On Thursday, September 26, 2013 9:08 PM, Tomi Valkeinen wrote: > On 26/09/13 14:51, Thierry Reding wrote: > > On Thu, Sep 26, 2013 at 01:03:06PM +0300, Tomi Valkeinen wrote: > > [...] > >> But if you and Thierry think this version is good, I'll take it. > > > > That sounds like you want to take it

Re: [PATCH v2] pwm-backlight: allow for non-increasing brightness levels

2013-09-26 Thread Jingoo Han
On Thursday, September 26, 2013 10:00 PM, Thierry Reding wrote: > On Thu, Sep 26, 2013 at 03:08:22PM +0300, Tomi Valkeinen wrote: > > On 26/09/13 14:51, Thierry Reding wrote: > > > On Thu, Sep 26, 2013 at 01:03:06PM +0300, Tomi Valkeinen wrote: > > > [...] > > >> But if you and Thierry think this

Re: [PATCH v2] pwm-backlight: allow for non-increasing brightness levels

2013-09-26 Thread Thierry Reding
On Thu, Sep 26, 2013 at 03:08:22PM +0300, Tomi Valkeinen wrote: > On 26/09/13 14:51, Thierry Reding wrote: > > On Thu, Sep 26, 2013 at 01:03:06PM +0300, Tomi Valkeinen wrote: > > [...] > >> But if you and Thierry think this version is good, I'll take it. > > > > That sounds like you want to take

Re: [PATCH v2] pwm-backlight: allow for non-increasing brightness levels

2013-09-26 Thread Tomi Valkeinen
On 26/09/13 14:51, Thierry Reding wrote: > On Thu, Sep 26, 2013 at 01:03:06PM +0300, Tomi Valkeinen wrote: > [...] >> But if you and Thierry think this version is good, I'll take it. > > That sounds like you want to take it through the fbdev tree. Jingoo is > listed (along with Richard, but he

Re: [PATCH v2] pwm-backlight: allow for non-increasing brightness levels

2013-09-26 Thread Thierry Reding
On Thu, Sep 26, 2013 at 01:03:06PM +0300, Tomi Valkeinen wrote: [...] > But if you and Thierry think this version is good, I'll take it. That sounds like you want to take it through the fbdev tree. Jingoo is listed (along with Richard, but he hasn't been responsive to email for years) as

Re: [PATCH v2] pwm-backlight: allow for non-increasing brightness levels

2013-09-26 Thread Tomi Valkeinen
On 22/09/13 19:59, Mike Dunn wrote: > Currently the driver assumes that the values specified in the > brightness-levels device tree property increase as they are parsed from > left to right. But boards that invert the signal between the PWM output > and the backlight will need to specify

Re: [PATCH v2] pwm-backlight: allow for non-increasing brightness levels

2013-09-26 Thread Tomi Valkeinen
On 22/09/13 19:59, Mike Dunn wrote: Currently the driver assumes that the values specified in the brightness-levels device tree property increase as they are parsed from left to right. But boards that invert the signal between the PWM output and the backlight will need to specify decreasing

Re: [PATCH v2] pwm-backlight: allow for non-increasing brightness levels

2013-09-26 Thread Thierry Reding
On Thu, Sep 26, 2013 at 01:03:06PM +0300, Tomi Valkeinen wrote: [...] But if you and Thierry think this version is good, I'll take it. That sounds like you want to take it through the fbdev tree. Jingoo is listed (along with Richard, but he hasn't been responsive to email for years) as

Re: [PATCH v2] pwm-backlight: allow for non-increasing brightness levels

2013-09-26 Thread Tomi Valkeinen
On 26/09/13 14:51, Thierry Reding wrote: On Thu, Sep 26, 2013 at 01:03:06PM +0300, Tomi Valkeinen wrote: [...] But if you and Thierry think this version is good, I'll take it. That sounds like you want to take it through the fbdev tree. Jingoo is listed (along with Richard, but he hasn't

Re: [PATCH v2] pwm-backlight: allow for non-increasing brightness levels

2013-09-26 Thread Thierry Reding
On Thu, Sep 26, 2013 at 03:08:22PM +0300, Tomi Valkeinen wrote: On 26/09/13 14:51, Thierry Reding wrote: On Thu, Sep 26, 2013 at 01:03:06PM +0300, Tomi Valkeinen wrote: [...] But if you and Thierry think this version is good, I'll take it. That sounds like you want to take it through

Re: [PATCH v2] pwm-backlight: allow for non-increasing brightness levels

2013-09-26 Thread Jingoo Han
On Thursday, September 26, 2013 10:00 PM, Thierry Reding wrote: On Thu, Sep 26, 2013 at 03:08:22PM +0300, Tomi Valkeinen wrote: On 26/09/13 14:51, Thierry Reding wrote: On Thu, Sep 26, 2013 at 01:03:06PM +0300, Tomi Valkeinen wrote: [...] But if you and Thierry think this version is

Re: [PATCH v2] pwm-backlight: allow for non-increasing brightness levels

2013-09-26 Thread Jingoo Han
On Thursday, September 26, 2013 9:08 PM, Tomi Valkeinen wrote: On 26/09/13 14:51, Thierry Reding wrote: On Thu, Sep 26, 2013 at 01:03:06PM +0300, Tomi Valkeinen wrote: [...] But if you and Thierry think this version is good, I'll take it. That sounds like you want to take it through the

[PATCH v2] pwm-backlight: allow for non-increasing brightness levels

2013-09-22 Thread Mike Dunn
Currently the driver assumes that the values specified in the brightness-levels device tree property increase as they are parsed from left to right. But boards that invert the signal between the PWM output and the backlight will need to specify decreasing brightness-levels. This patch removes the

[PATCH v2] pwm-backlight: allow for non-increasing brightness levels

2013-09-22 Thread Mike Dunn
Currently the driver assumes that the values specified in the brightness-levels device tree property increase as they are parsed from left to right. But boards that invert the signal between the PWM output and the backlight will need to specify decreasing brightness-levels. This patch removes the