Re: [PATCH v2] pwm-backlight: fix the panel power sequence

On Thu, 2015-11-05 at 10:40 +0100, Philipp Zabel wrote: > > > > Based on this, could we disable it initially and update in the > > backlight_update_status function? > > > > Like this, > > > > if (pb->enable_gpio) { > > if (phandle && > > gpiod_get_direction(pb->enable_gpio) ==

Re: [PATCH v2] pwm-backlight: fix the panel power sequence

On Thu, 2015-11-05 at 10:40 +0100, Philipp Zabel wrote: > > > > Based on this, could we disable it initially and update in the > > backlight_update_status function? > > > > Like this, > > > > if (pb->enable_gpio) { > > if (phandle && > > gpiod_get_direction(pb->enable_gpio) ==

Re: [PATCH v2] pwm-backlight: fix the panel power sequence

Am Mittwoch, den 04.11.2015, 09:47 +0800 schrieb YH Huang: > On Tue, 2015-11-03 at 12:08 +0100, Philipp Zabel wrote: > > Hi YH, > > > > Am Dienstag, den 03.11.2015, 16:11 +0800 schrieb YH Huang: > > > > The reasoning is that devices where there is no phandle link pointing to > > > > the backlight

Re: [PATCH v2] pwm-backlight: fix the panel power sequence

Am Mittwoch, den 04.11.2015, 09:47 +0800 schrieb YH Huang: > On Tue, 2015-11-03 at 12:08 +0100, Philipp Zabel wrote: > > Hi YH, > > > > Am Dienstag, den 03.11.2015, 16:11 +0800 schrieb YH Huang: > > > > The reasoning is that devices where there is no phandle link pointing to > > > > the backlight

Re: [PATCH v2] pwm-backlight: fix the panel power sequence

On Tue, 2015-11-03 at 12:08 +0100, Philipp Zabel wrote: > Hi YH, > > Am Dienstag, den 03.11.2015, 16:11 +0800 schrieb YH Huang: > > > The reasoning is that devices where there is no phandle link pointing to > > > the backlight (for example from a simple-panel node), we should keep the > > >

Re: [PATCH v2] pwm-backlight: fix the panel power sequence

Hi YH, Am Dienstag, den 03.11.2015, 16:11 +0800 schrieb YH Huang: > > The reasoning is that devices where there is no phandle link pointing to > > the backlight (for example from a simple-panel node), we should keep the > > current default behaviour (enable during probe). > > I have a little

Re: [PATCH v2] pwm-backlight: fix the panel power sequence

On Fri, 2015-10-30 at 11:34 +0100, Philipp Zabel wrote: > Am Freitag, den 30.10.2015, 15:41 +0800 schrieb YH Huang: > > > That won't work if the gpio is still configured as input. How about I > > > add the GPIOD_ASIS change to my patch you remove that and the above from > > > yours? > > > > I

Re: [PATCH v2] pwm-backlight: fix the panel power sequence

On Fri, 2015-10-30 at 11:34 +0100, Philipp Zabel wrote: > Am Freitag, den 30.10.2015, 15:41 +0800 schrieb YH Huang: > > > That won't work if the gpio is still configured as input. How about I > > > add the GPIOD_ASIS change to my patch you remove that and the above from > > > yours? > > > > I

Re: [PATCH v2] pwm-backlight: fix the panel power sequence

Hi YH, Am Dienstag, den 03.11.2015, 16:11 +0800 schrieb YH Huang: > > The reasoning is that devices where there is no phandle link pointing to > > the backlight (for example from a simple-panel node), we should keep the > > current default behaviour (enable during probe). > > I have a little

Re: [PATCH v2] pwm-backlight: fix the panel power sequence

On Tue, 2015-11-03 at 12:08 +0100, Philipp Zabel wrote: > Hi YH, > > Am Dienstag, den 03.11.2015, 16:11 +0800 schrieb YH Huang: > > > The reasoning is that devices where there is no phandle link pointing to > > > the backlight (for example from a simple-panel node), we should keep the > > >

Re: [PATCH v2] pwm-backlight: fix the panel power sequence

Am Freitag, den 30.10.2015, 15:41 +0800 schrieb YH Huang: > > That won't work if the gpio is still configured as input. How about I > > add the GPIOD_ASIS change to my patch you remove that and the above from > > yours? > > I revise these two lines > if (pb->enable_gpio) >

Re: [PATCH v2] pwm-backlight: fix the panel power sequence

Hi Hpilipp, On Thu, 2015-10-29 at 16:40 +0100, Philipp Zabel wrote: > Hi YH, > > Am Donnerstag, den 22.10.2015, 23:12 +0800 schrieb YH Huang: > > In the case of the panel disabled by the bootloader, > > your patch still has the following code and always enables the backlight > > in the probe

Re: [PATCH v2] pwm-backlight: fix the panel power sequence

Hi Hpilipp, On Thu, 2015-10-29 at 16:40 +0100, Philipp Zabel wrote: > Hi YH, > > Am Donnerstag, den 22.10.2015, 23:12 +0800 schrieb YH Huang: > > In the case of the panel disabled by the bootloader, > > your patch still has the following code and always enables the backlight > > in the probe

Re: [PATCH v2] pwm-backlight: fix the panel power sequence

Am Freitag, den 30.10.2015, 15:41 +0800 schrieb YH Huang: > > That won't work if the gpio is still configured as input. How about I > > add the GPIOD_ASIS change to my patch you remove that and the above from > > yours? > > I revise these two lines > if (pb->enable_gpio) >

Re: [PATCH v2] pwm-backlight: fix the panel power sequence

Hi YH, Am Donnerstag, den 22.10.2015, 23:12 +0800 schrieb YH Huang: > In the case of the panel disabled by the bootloader, > your patch still has the following code and always enables the backlight > in the probe function. > pb->enable_gpio = devm_gpiod_get_optional(>dev, "enable", > -

Re: [PATCH v2] pwm-backlight: fix the panel power sequence

Hi YH, Am Donnerstag, den 22.10.2015, 23:12 +0800 schrieb YH Huang: > In the case of the panel disabled by the bootloader, > your patch still has the following code and always enables the backlight > in the probe function. > pb->enable_gpio = devm_gpiod_get_optional(>dev, "enable", > -

Re: [PATCH v2] pwm-backlight: fix the panel power sequence

On Fri, 2015-10-16 at 11:36 +0200, Philipp Zabel wrote: > Am Freitag, den 16.10.2015, 17:17 +0800 schrieb YH Huang: > > In order to match the panel power sequence, disable the enable_gpio > > in the probe function. Also, reorder the code in the power_on and > > power_off function to match the

Re: [PATCH v2] pwm-backlight: fix the panel power sequence

On Fri, 2015-10-16 at 11:36 +0200, Philipp Zabel wrote: > Am Freitag, den 16.10.2015, 17:17 +0800 schrieb YH Huang: > > In order to match the panel power sequence, disable the enable_gpio > > in the probe function. Also, reorder the code in the power_on and > > power_off function to match the

Re: [PATCH v2] pwm-backlight: fix the panel power sequence

Am Freitag, den 16.10.2015, 17:17 +0800 schrieb YH Huang: > In order to match the panel power sequence, disable the enable_gpio > in the probe function. Also, reorder the code in the power_on and > power_off function to match the timing. Could you also have a look at the "pwm-backlight: Avoid

[PATCH v2] pwm-backlight: fix the panel power sequence

In order to match the panel power sequence, disable the enable_gpio in the probe function. Also, reorder the code in the power_on and power_off function to match the timing. Signed-off-by: YH Huang --- Change in v2: Fix the build error. --- drivers/video/backlight/pwm_bl.c | 14 +-

[PATCH v2] pwm-backlight: fix the panel power sequence

In order to match the panel power sequence, disable the enable_gpio in the probe function. Also, reorder the code in the power_on and power_off function to match the timing. Signed-off-by: YH Huang --- Change in v2: Fix the build error. ---

Re: [PATCH v2] pwm-backlight: fix the panel power sequence

Am Freitag, den 16.10.2015, 17:17 +0800 schrieb YH Huang: > In order to match the panel power sequence, disable the enable_gpio > in the probe function. Also, reorder the code in the power_on and > power_off function to match the timing. Could you also have a look at the "pwm-backlight: Avoid