Re: [PATCH v2] regulator: devres: introduce managed enable and disable operations

2017-02-22 Thread Dmitry Torokhov
On Tue, Feb 21, 2017 at 10:56:34AM -0800, Mark Brown wrote: > On Tue, Feb 21, 2017 at 12:30:03AM -0800, Dmitry Torokhov wrote: > > On Mon, Feb 20, 2017 at 11:02:58AM -0800, Mark Brown wrote: > > > On Mon, Feb 13, 2017 at 10:51:52AM -0800, Dmitry Torokhov wrote: > > > But that is what I meant here a

Re: [PATCH v2] regulator: devres: introduce managed enable and disable operations

2017-02-21 Thread Mark Brown
On Tue, Feb 21, 2017 at 12:30:03AM -0800, Dmitry Torokhov wrote: > On Mon, Feb 20, 2017 at 11:02:58AM -0800, Mark Brown wrote: > > On Mon, Feb 13, 2017 at 10:51:52AM -0800, Dmitry Torokhov wrote: > But that is what I meant here about managed action. You are not > interacting with managed regulator

Re: [PATCH v2] regulator: devres: introduce managed enable and disable operations

2017-02-21 Thread Dmitry Torokhov
On Mon, Feb 20, 2017 at 11:02:58AM -0800, Mark Brown wrote: > On Mon, Feb 13, 2017 at 10:51:52AM -0800, Dmitry Torokhov wrote: > > > I think it is helps if you think about devm_regulator_enable and regular > > regulator_enable as managed and unmanaged *actions*, not resources. So > > That's how I

Re: [PATCH v2] regulator: devres: introduce managed enable and disable operations

2017-02-20 Thread Mark Brown
On Mon, Feb 13, 2017 at 10:51:52AM -0800, Dmitry Torokhov wrote: > I think it is helps if you think about devm_regulator_enable and regular > regulator_enable as managed and unmanaged *actions*, not resources. So That's how I see them but it's still not really helping my concern, in general if yo

Re: [PATCH v2] regulator: devres: introduce managed enable and disable operations

2017-02-13 Thread Dmitry Torokhov
On Mon, Feb 13, 2017 at 06:01:29PM +, Mark Brown wrote: > On Sun, Feb 12, 2017 at 06:32:49PM -0800, Dmitry Torokhov wrote: > > > v2: restored lost regulator_disable() stub > > > Mark, note that there is also patch introducing devm_clk_prepare() and > > devm_clk_prepare_enable() that Russell d

Re: [PATCH v2] regulator: devres: introduce managed enable and disable operations

2017-02-13 Thread Mark Brown
On Sun, Feb 12, 2017 at 06:32:49PM -0800, Dmitry Torokhov wrote: > v2: restored lost regulator_disable() stub > Mark, note that there is also patch introducing devm_clk_prepare() and > devm_clk_prepare_enable() that Russell did not hate so I think it will > get applied eventually. I believe lack

[PATCH v2] regulator: devres: introduce managed enable and disable operations

2017-02-12 Thread Dmitry Torokhov
While preferred time to power up the device is when there are users of it present (i.e. when device is "open"ed), there are times when it makes more sense to power up the device in probe(). One such example is when device is expected to be always used (such as a touchscreen on a mobile device, or s