On Sat, Jul 13, 2013 at 12:15:12AM +0800, Robin Gong wrote:
Please fix your mail program to word wrap between paragraphs.
> On Fri, Jul 12, 2013 at 03:40:37PM +0100, Mark Brown wrote:
> > > +static const int pfuze100_swbst[] = {
> > > + 500, 505, 510, 515,
> > > +};
> > This loo
On Mon, Jul 15, 2013 at 02:40:39PM +0800, Robin Gong wrote:
> > > +static const struct of_device_id pfuze_dt_ids[] = {
> > > + { .compatible = "fsl,pfuze100", .data = (void *)PFUZE_ID_PFUZE100},
> >
> > You do not use .data in the driver at all, and can just drop it.
> >
> good catch. .driver_data
Shawn, Thanks for your carefully review and I will correct it and send the
patch again. some comments below:
> > +
> > +struct pfuze_regulator {
> > + struct regulator_desc desc;
> > + unsigned char stby_reg;
> > + unsigned char stby_mask;
> > +};
> > +
> > +enum pfuze_id {
> > + PFUZE_ID_
The patch looks good. Comments below are mostly random coding style
nitpicks.
On Fri, Jul 12, 2013 at 12:54:15PM +0800, Robin Gong wrote:
> Add pfuze100 regulator driver.
>
> Signed-off-by: Robin Gong
> ---
> .../devicetree/bindings/regulator/pfuze100.txt | 113 +
> drivers/regulator/
Mark,
Thanks for your kindly review, please see below comments.
On Fri, Jul 12, 2013 at 03:40:37PM +0100, Mark Brown wrote:
> On Fri, Jul 12, 2013 at 12:54:15PM +0800, Robin Gong wrote:
> > Add pfuze100 regulator driver.
>
> This looks mostly good. A few small issues below but nothing m
On Fri, Jul 12, 2013 at 12:54:15PM +0800, Robin Gong wrote:
> Add pfuze100 regulator driver.
This looks mostly good. A few small issues below but nothing major.
> +enum pfuze_id {
> + PFUZE_ID_PFUZE100,
> + PFUZE_ID_INVALID,
> +};
> +struct pfuze_chip {
Missing blank line here - there a
Add pfuze100 regulator driver.
Signed-off-by: Robin Gong
---
.../devicetree/bindings/regulator/pfuze100.txt | 113 +
drivers/regulator/Kconfig |7 +
drivers/regulator/Makefile |1 +
drivers/regulator/pfuze100-regulator.c
Add pfuze100 regulator driver.
Signed-off-by: Robin Gong
---
.../devicetree/bindings/regulator/pfuze100.txt | 113 +
drivers/regulator/Kconfig |7 +
drivers/regulator/Makefile |1 +
drivers/regulator/pfuze100-regulator.c
8 matches
Mail list logo
